fix: 🩹 Minor integration test and comment fixes (and testing Blacksmith runners) #2932
ffaralllint.yml
on: pull_request
Check format with rustfmt
37s
Check lint with clippy
1m 21s
Check format with biome
23s
Check lint with biome
18s
Typecheck with tsc
22s
Annotations
11 warnings
|
Check lint with clippy
Unsupported Cargo.lock format, fallback to caching entire file
|
|
Check lint with clippy:
pallets/randomness/src/benchmarking.rs#L6
bound is defined in more than one place
|
|
Check lint with clippy:
pallets/randomness/src/lib.rs#L198
using `map_err` over `inspect_err`
|
|
Check lint with clippy:
pallets/providers/src/benchmarking.rs#L581
using `clone` on type `<T as Config>::ProviderId` which implements the `Copy` trait
|
|
Check lint with clippy:
pallets/providers/src/lib.rs#L1557
using `map_err` over `inspect_err`
|
|
Check lint with clippy:
pallets/proofs-dealer/src/lib.rs#L757
using `map_err` over `inspect_err`
|
|
Check lint with clippy:
pallets/provider-randomness/src/lib.rs#L577
useless conversion to the same type: `std::collections::btree_set::Difference<'_, <<T as pallet_proofs_dealer::Config>::ProvidersPallet as shp_traits::ReadChallengeableProvidersInterface>::ProviderId>`
|
|
Check lint with clippy:
pallets/provider-randomness/src/lib.rs#L627
called `expect` on `providers_to_mark` after checking its variant with `is_some`
|
|
Check lint with clippy:
pallets/provider-randomness/src/lib.rs#L560
using `map_err` over `inspect_err`
|
|
Check lint with clippy:
pallets/payment-streams/src/lib.rs#L413
using `map_err` over `inspect_err`
|
|
Check lint with clippy:
pallets/file-system/src/utils.rs#L74
the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable
|