common: flush streams before closing them

On loaded systems slow tty can give false positive exit failure due pending bytes. Flush the streams that hopefully makes these problems less likely. Reference: iputils@4655ecc#commitcomment-36628770 Signed-off-by: Sami Kerola <[email protected]>
Mingli-Yu · Jan 6, 2020 · 2308234 · 2308234
1 parent 2705c82
commit 2308234
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/iputils_common.c b/iputils_common.c
@@ -33,13 +33,15 @@ void error(int status, int errnum, const char *format, ...)
 
 int close_stream(FILE *stream)
 {
+	const int flush_status = fflush(stream);
 #ifdef HAVE___FPENDING
 	const int some_pending = (__fpending(stream) != 0);
 #endif
 	const int prev_fail = (ferror(stream) != 0);
 	const int fclose_fail = (fclose(stream) != 0);
 
-	if (prev_fail || (fclose_fail && (
+	if (flush_status ||
+	    prev_fail || (fclose_fail && (
 #ifdef HAVE___FPENDING
 					  some_pending ||
 #endif