Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use forked license-checker with fixed dependencies #7

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

legobeat
Copy link

@legobeat legobeat commented May 3, 2023

@legobeat legobeat requested review from sethkfman and a team May 3, 2023 01:57
@socket-security
Copy link

socket-security bot commented May 3, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/[email protected]
Unpublished package npm/@metamask/[email protected]
  • Version: Invalid Date

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What are unpublished packages?

Package version was not found on the registry. It may exist on a different registry and need to be configured to pull from that registry.

Packages can be removed from the registry by manually un-publishing, a security issue removal, or may simply never have been published to the registry. Reliance on these packages will cause problem when they are not found.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Author

legobeat commented May 3, 2023

@SocketSecurity ignore [email protected]

@legobeat legobeat force-pushed the deps-fork-license-checker branch from a13ecf0 to 913f74b Compare May 11, 2023 11:03
@legobeat legobeat requested a review from a team as a code owner May 11, 2023 11:03
@legobeat
Copy link
Author

@SocketSecurity ignore [email protected]

@legobeat legobeat requested review from sethkfman and removed request for sethkfman July 12, 2023 11:44
@legobeat legobeat force-pushed the deps-fork-license-checker branch from 913f74b to 5f77dd0 Compare July 31, 2023 16:05
@legobeat
Copy link
Author

legobeat commented Aug 1, 2023

@SocketSecurity ignore [email protected]

@legobeat
Copy link
Author

@sethkfman Did you have a chance to take a look here yet? :)

MetaMask/metamask-mobile#6306 (comment)

@legobeat legobeat requested a review from leotm October 17, 2023 21:54
@legobeat legobeat force-pushed the deps-fork-license-checker branch from 5f77dd0 to 33064c5 Compare October 17, 2023 21:56
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 17, 2023
@legobeat legobeat mentioned this pull request Oct 17, 2023
3 tasks
@legobeat legobeat force-pushed the deps-fork-license-checker branch from 33064c5 to 63cc777 Compare October 18, 2023 08:18
package.json Outdated Show resolved Hide resolved
@legobeat legobeat force-pushed the deps-fork-license-checker branch from 63cc777 to c4321bc Compare October 18, 2023 09:15
@legobeat legobeat requested a review from Mrtenz November 13, 2023 03:02
@legobeat legobeat force-pushed the deps-fork-license-checker branch from c4321bc to 1de4ad1 Compare November 13, 2023 03:02
@legobeat legobeat requested a review from a team November 16, 2023 01:29
@legobeat legobeat force-pushed the deps-fork-license-checker branch from 1de4ad1 to 3dc535f Compare February 8, 2024 16:42
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: environment, filesystem +54 1.08 MB

🚮 Removed packages: npm/[email protected]

View full report↗︎

@legobeat
Copy link
Author

legobeat commented Feb 8, 2024

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@metamask/[email protected]

nopt: new author ok
@metamask/license-checker: is actually not unpublished; just recent

@legobeat legobeat marked this pull request as ready for review February 8, 2024 16:45
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 167854c into MetaMask:main Feb 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants