-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(devDeps): Use updated fork of oss-attribution-generator #6306
chore(devDeps): Use updated fork of oss-attribution-generator #6306
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
6fea769
to
7c59d16
Compare
e80d2ba
to
a9564e4
Compare
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
@github-actions: Not stale but waiting for MetaMask/oss-attribution-generator#7 |
a9564e4
to
7b40575
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected] |
shell access ok |
7b40575
to
c8c4dff
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6306 +/- ##
=======================================
Coverage 34.61% 34.61%
=======================================
Files 1019 1019
Lines 27193 27193
Branches 2218 2218
=======================================
Hits 9413 9413
Misses 17289 17289
Partials 491 491 ☔ View full report in Codecov by Sentry. |
255a22c
to
5b7e96e
Compare
5b7e96e
to
c5daa09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work 💪 and thx for tidying up the resolutions
noticed on main
running yarn build:attribution
and yarn test:attribution-check
# ...
processing [email protected]
processing zip-stream for authors and licenseText
processing [email protected]
processing zxcvbn for authors and licenseText
@metamask/react-native-button: unable to locate package.json
error Command failed with exit code 1.
and https://github.com/MetaMask/metamask-mobile/blob/main/attribution.txt hasn't been updated since last year (cc @wachunei spotted last update was yours), so this could be why
but not worth raising as a v1.7.1 issue since being replaced by v2.0.0
then in this pr (v2.0.0) running yarn build:attribution
and yarn test:attribution-check
# ...
processing @metamask/preferences-controller for authors and licenseText
processing @metamask/[email protected]
processing @metamask/preferences-controller for authors and licenseText
processing @metamask/[email protected]
TypeError: Assignment to constant variable.
at Object.<anonymous> (/Users/leo/Documents/GitHub/metamask-mobile/node_modules/@metamask/oss-attribution-generator/index.js:115:31)
at Array.map (<anonymous>)
at /Users/leo/Documents/GitHub/metamask-mobile/node_modules/@metamask/oss-attribution-generator/index.js:105:35
at runMicrotasks (<anonymous>)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
error Command failed with exit code 1.
so perhaps worth raising an issue to fix in v2.0.1 then update to that as follow-up?
@leotm Good catches!
|
20523bc
to
9c09a1b
Compare
9c09a1b
to
a458d40
Compare
a458d40
to
b07906e
Compare
|
Description
This package was last updated in 2018, by now over 5 years ago.
This replaces it with an updated fork with several obsolete dependencies removed or updated.
npmdiff
Blocked by
Checklist