Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: support more QR code versions #5

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

denysvitali
Copy link
Contributor

Relates to #2 .

In this branch I'm currently creating a way to dynamically create a QR template based on the version, and without using any templates.

So far I was able to create a QR code from scratch by just generating everything dynamically, with the following elements:

  • Finders
  • Alignment Patterns + Spacing

To be equally comparable to the provided templates, I'd need to add the version information - but I'm kind of stuck here since I still need to read the spec about it.

Here is an example of how the QR code looks like now:
image

I have also created two pages (index2.html and finder-example.html) to be able to debug the two versions (hardcoded template vs generated QR), to make the debugging easier. Of course these two pages will not be part of the final commits (or they'll be placed in a debug directory).

@Merricx Merricx merged commit a793919 into Merricx:master Apr 24, 2023
@denysvitali denysvitali deleted the feature/support-more-versions branch May 29, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants