Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2 .
In this branch I'm currently creating a way to dynamically create a QR template based on the version, and without using any templates.
So far I was able to create a QR code from scratch by just generating everything dynamically, with the following elements:
To be equally comparable to the provided templates, I'd need to add the version information - but I'm kind of stuck here since I still need to read the spec about it.
Here is an example of how the QR code looks like now:
I have also created two pages (index2.html and finder-example.html) to be able to debug the two versions (hardcoded template vs generated QR), to make the debugging easier. Of course these two pages will not be part of the final commits (or they'll be placed in a
debug
directory).