-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support up to v40 and some UI enhancements + import/export text file #6
Conversation
wip: support more QR code versions
add version info , add dark module
switch qr_template array to denisvitalys generate_qr() (qr.js) resize to acceptable QR size pixel width ( main + padding windows)
complete all tables info for up to version 40 of QR version size
normal decode will work for v40
decode mode need 2px width module for correct decoding , also it now support switching up or lower and reverting to original encode pixel module settings before decode mode being used
QR higher version bit parsing fix (num, alphanum, byte)
quoted all 0 & 1
Step by step
This PR is linked to #2 . |
Such nice works! Let me check it and then I will merge to master. By the way, any specific reason why you renamed "padding" term into "patching" ? I think padding make more sense because they are literally padding bits |
Imam, I renamed because in branch step-by-step , it is reused to show all change after "patching" . Step-by-step branch did a refactoring , I combined all decoding related activity into one function instead of having that same thing redone for RS , Padding , Strong Decoder and ReadDatabits. Also Kanji decoding works in Strong Decoder ( but not on the normal decode section ). I am still Work-in-progress on that branch . Segment patching don't have the apply button commited yet. |
@Darkar25 well version is already colored red (if QR size is version 7 or higher ) and not editable and it is filled for you based on selected new size or recognised size , format is only editable when clicking on the QR format info location. for educational purpose , it would be great to separate highlight . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the "O" and "o" symbols make 0 instead of 1?
Hi Darkar25, it is directly taken from Waidotto ( https://github.com/waidotto/strong-qr-decoder ) Readme.md 使い方
Which translate to : How to use
:) |
oh...ok) |
@Darkar25 It is from the Japanese Culture for the O and X Notation : O mean yes / true / Correct , X mean no / false / error . |
Hi Imam,
Best Wishes
Here is a single PR for :
support up to v40 ( based wip work of Denys Vitali #5 ) and fixing strong decoder/RS/recover padding.
some UI enhancements ( dynamic resize based on QR size for encode and decode mode )
import/export text file
Best regards
Phi Phi