Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IN 1165 - 2025-01 maintenance #155

Merged
merged 5 commits into from
Feb 5, 2025
Merged

IN 1165 - 2025-01 maintenance #155

merged 5 commits into from
Feb 5, 2025

Conversation

ghukill
Copy link
Contributor

@ghukill ghukill commented Jan 31, 2025

Purpose and background context

This PR performs regular maintenance for this application.

Updates include:

  • bump python version to 3.12
  • update dependencies
  • update README for testing in stage
  • reviewed open issues, none found
  • added CODEOWNERS file
  • added "Related Assets" and "Maintainers" section to README.md (preview)

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

@coveralls
Copy link

coveralls commented Jan 31, 2025

Pull Request Test Coverage Report for Build 13119811607

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8195063392: 0.0%
Covered Lines: 230
Relevant Lines: 230

💛 - Coveralls

@ghukill ghukill force-pushed the IN-1165-maintenance-2025-01 branch from 4813a36 to f6232a0 Compare January 31, 2025 22:08
@ghukill ghukill requested review from a team and adamshire123 February 3, 2025 14:21
Copy link
Contributor

@ehanson8 ehanson8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line in CODEOWNERS may need fixing but otherwise looks good!

.github/CODEOWNERS Outdated Show resolved Hide resolved
@ghukill ghukill requested a review from ehanson8 February 3, 2025 18:02
@ghukill ghukill merged commit 5873dea into main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants