Fix SudoMain DynamicFontSize : Resolved circular dependencies between…

… them with fxmlService.setDynamicFontSize() method.
Lob2018 · Feb 5, 2025 · 2da7a30 · 2da7a30
1 parent 6ab1a04
commit 2da7a30
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/main/java/fr/softsf/sudokufx/SudoMain.java b/src/main/java/fr/softsf/sudokufx/SudoMain.java
@@ -174,7 +174,7 @@ private void initializeFxmlService() {
         if (fxmlService == null) {
             fxmlService = new FxmlService(new FXMLLoader());
         }
-        fxmlService.setDynamicFontSize(new DynamicFontSize());
+        fxmlService.setDynamicFontSize();
     }
 
     /**

diff --git a/src/main/java/fr/softsf/sudokufx/service/FxmlService.java b/src/main/java/fr/softsf/sudokufx/service/FxmlService.java
@@ -6,7 +6,6 @@
 import javafx.application.Platform;
 import javafx.fxml.FXMLLoader;
 import javafx.scene.Scene;
-import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
 
@@ -24,7 +23,6 @@ public class FxmlService implements ISceneProvider {
 
     private final FXMLLoader fxmlLoader;
 
-    @Setter
     private DynamicFontSize dynamicFontSize;
 
     /**
@@ -38,6 +36,13 @@ public FxmlService(FXMLLoader fxmlLoader) {
         this.fxmlLoader = fxmlLoader;
     }
 
+    /**
+     * Initializes dynamic font sizing for the scene.
+     */
+    public void setDynamicFontSize() {
+        this.dynamicFontSize = new DynamicFontSize();
+    }
+
     /**
      * Sets the root of the scene based on the given FXML file name, and adapt the font size dynamically
      *