Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handling around simulation not working properly #50

Open
LinqLover opened this issue Mar 13, 2022 · 0 comments
Open

Exception handling around simulation not working properly #50

LinqLover opened this issue Mar 13, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@LinqLover
Copy link
Owner

Given:

[(Simulator evaluate: [self error]) + 1] on: Error do: [2]

Expected answer: 2
Actual answer: 3
⚠️ In non-optimized mode (contextAtEachStep: [:c|]), the execution escapes from the simulator!
In Sandbox2, the issue does not occur.
@LinqLover LinqLover added the bug Something isn't working label Mar 13, 2022
This was referenced Mar 13, 2022
Closed
Merged
LinqLover added a commit to hpi-swa-lab/squeak-tracedebugger that referenced this issue May 10, 2022
@LinqLover
Enable isolation during retracing
d2dfd70 
This makes sure that we finally can read our own writes during retracing, adhering to the normal execution semantics. Also, this fixes #52 as described in LinqLover/SimulationStudio#50.

Consequential changes:

- Update kernel tests: use exception handling protocol, update testGroups/expectedFailures
- Test read-your-own-writes
- Adjust proxy client code to honor the fact that implicit side-effects (different from the return value) are no longer possible:
	* TDBCursor>>#livingHomeTraceFor:
	* TDBInspector>>#replaceInspectorWithExplorer
		+ Refactor view decoration in proxy holders: Always rebuild view (nuke deep model replacement) to avoid inconsistencies from first view. Improve MVC compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LinqLover