Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation/code creation inside Sandbox #38

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Conversation

LinqLover
Copy link
Owner

@LinqLover LinqLover commented Dec 29, 2021

Open issues:

  • #testClassComment fails because accesses to the FilePlugin are not allowed - we could either create an exception for the sources file or process these requests outside of the sandbox.
  • #testSubclass crashes the VM because of something we are doing wrong/differently than normal Trunk during the behavior creation. See: http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217860.html

@LinqLover LinqLover added the enhancement New feature or request label Dec 29, 2021
Open issues:

* #testClassComment fails because accesses to the FilePlugin are not allowed - we could either create an exception for the sources file or process these requests outside of the sanfbox.
* #testSubclass crashes the VM because of something we are doing wrong/differently than normal Trunk during the behavior creation. See: http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217860.html
@LinqLover LinqLover force-pushed the feat/sandbox-compilation branch from 432e301 to f3b762e Compare December 29, 2021 18:22
@LinqLover
Copy link
Owner Author

LinqLover commented Mar 14, 2022

For sandboxes, different attack vectors should be discussed when it becomes possible to generate new source code inside the simulator:

  • See SimulationContext>>#runSimulated:contextAtEachStep:: Could the simulated code try to manipulate the context stack in a way that an injected context looks like the final resume/ensure context, and how should we handle this? Discuss together with Exception handling around simulation not working properly #50.

@LinqLover LinqLover merged commit 42321f8 into master Sep 20, 2022
@LinqLover LinqLover deleted the feat/sandbox-compilation branch September 20, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant