Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector field error texts are not displayed properly #52

Closed
LinqLover opened this issue Mar 13, 2022 · 1 comment · Fixed by #78
Closed

Inspector field error texts are not displayed properly #52

LinqLover opened this issue Mar 13, 2022 · 1 comment · Fixed by #78
Labels
bug Something isn't working upstream

Comments

@LinqLover
Copy link
Collaborator

A virgin fraction (Fraction basicNew) looks like this in a regular debugger/inspector:
image

In the TraceDebugger's inspector, it looks like this instead:
image

An error from a custom inspector field looks like this in a regular debugger/inspector:
image

In the TraceDebugger's inspector, it looks like this instead:
image
@LinqLover LinqLover added the bug Something isn't working label Mar 13, 2022
@LinqLover
Copy link
Collaborator Author

Caused by LinqLover/SimulationStudio#50 in connection with the exception handler in Inspector>>#updateContentsSafely.

LinqLover added a commit that referenced this issue May 10, 2022
@LinqLover
Enable isolation during retracing
d2dfd70 
This makes sure that we finally can read our own writes during retracing, adhering to the normal execution semantics. Also, this fixes #52 as described in LinqLover/SimulationStudio#50.

Consequential changes:

- Update kernel tests: use exception handling protocol, update testGroups/expectedFailures
- Test read-your-own-writes
- Adjust proxy client code to honor the fact that implicit side-effects (different from the return value) are no longer possible:
	* TDBCursor>>#livingHomeTraceFor:
	* TDBInspector>>#replaceInspectorWithExplorer
		+ Refactor view decoration in proxy holders: Always rebuild view (nuke deep model replacement) to avoid inconsistencies from first view. Improve MVC compatibility.
@LinqLover LinqLover linked a pull request May 10, 2022 that will close this issue
Historic state queries #78
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Historic state queries hpi-swa-lab/squeak-tracedebugger
1 participant
@LinqLover