Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rotation bug in rectangle random sampling #1597

Merged
merged 5 commits into from
Dec 9, 2023
Merged

fix rotation bug in rectangle random sampling #1597

merged 5 commits into from
Dec 9, 2023

Conversation

tomsilver
Copy link
Collaborator

@tomsilver tomsilver commented Dec 9, 2023 •
edited
Loading

before:
rectangle_unit_test_before

after:
rectangle_unit_test_after

NishanthJKumar
NishanthJKumar approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@NishanthJKumar NishanthJKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops my bad! Good catch!

@tomsilver tomsilver merged commit 94a237e into master Dec 9, 2023
6 checks passed
@tomsilver tomsilver deleted the fix-geom-random branch December 9, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NishanthJKumar NishanthJKumar NishanthJKumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomsilver @NishanthJKumar