Skip to content

Commit

Permalink
Merge branch 'master' into tomsilver-patch-1
Browse files Browse the repository at this point in the history
  • Loading branch information
tomsilver authored Nov 21, 2023
2 parents 9f87a48 + 0bdd180 commit dfd9ce4
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ omit =
predicators/envs/kitchen.py
predicators/perception/kitchen_perceiver.py
predicators/ground_truth_models/kitchen/**
# Currently disabled due to flakiness in the SME dependency.
predicators/approaches/sme_pg3_analogy_approach.py

[report]
# Regexes for lines to exclude from consideration
Expand Down
10 changes: 8 additions & 2 deletions tests/approaches/test_pg3_analogy_approach.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,14 @@ def test_pg3_analogy_approach():
)"""


def test_find_env_analogies():
"""Tests for _find_env_analogies()."""
def _disabled_test_find_env_analogies(): # pragma: no cover
"""Tests for _find_env_analogies().
NOTE: this test is currently disabled because of sudden flakiness in the
SME depedency, despite no changes for months. Since we're not actively
using this code, we're just disabling it, but leaving it here in case we
do want to resurrect the code in the future.
"""
# Test for gripper -> ferry.
base_env = create_new_env("pddl_gripper_procedural_tasks")
base_nsrts = get_gt_nsrts(base_env.get_name(), base_env.predicates,
Expand Down
8 changes: 6 additions & 2 deletions tests/envs/test_pybullet_cover.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,12 @@ def test_pybullet_cover_step(env):
assert abs(state.get(block, "pose") - 0.75) < 0.01


def test_pybullet_cover_pick_workspace_bounds(env):
"""Tests for picking at workspace bounds in PyBulletCoverEnv."""
def _disabled_test_pybullet_cover_pick_workspace_bounds(
env): # pragma: no cover
"""Tests for picking at workspace bounds in PyBulletCoverEnv.
This is currently disabled due to nondeterminism issues in IK.
"""
block = Object("block0", env.block_type)
robot = env.robot
workspace_x, workspace_z = env.workspace_dimensions
Expand Down

0 comments on commit dfd9ce4

Please sign in to comment.