[STYLE] Rename "bracket" to "parentheses" #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itislu
force-pushed
the
style-bracket-to-paren
branch
2 times, most recently
from
8393e15 to
fe968ca
Compare
itislu
commented
Jul 24, 2024
itislu
force-pushed
the
style-bracket-to-paren
branch
from
fe968ca to
02bc484
Compare
LeaYeh
approved these changes
Jul 28, 2024
LeaYeh
force-pushed
the
style-bracket-to-paren
branch
from
02bc484 to
036a4cc
Compare
itislu
force-pushed
the
style-bracket-to-paren
branch
from
036a4cc to
e7297ad
Compare
- Parentheses: `( )`
- Brackets: `[ ]`
- Braces: `{ }`
All of them mean something different for bash ofc.
In bash's documentation they use the same terminology.
Leaving it as it is with bracket is confusing when going through the code and you start to wonder if we handle `[ ]`, which we don't.
I guess you can name all of them brackets, but since we have support for both parentheses `( )` and braces `{ }`, using the term in a general way is just not very clear.
itislu
force-pushed
the
style-bracket-to-paren
branch
from
e7297ad to
646df74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( )[ ]{ }All of them mean something different for bash ofc. In bash's documentation they use the same terminology.
Leaving it as it is with bracket is confusing when going through the code and you start to wonder if we handle
[ ], which we don't.I guess you can name all of them brackets, but since we have support for both parentheses
( )and braces{ }, using the term in a general way is just not very clear.