Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE] Rename "bracket" to "parentheses" in code #362

Closed
itislu opened this issue Jul 23, 2024 · 0 comments · Fixed by #364
Closed

[STYLE] Rename "bracket" to "parentheses" in code #362

itislu opened this issue Jul 23, 2024 · 0 comments · Fixed by #364
Assignees
Labels
chore A routine task

Comments

@itislu
Copy link
Collaborator

itislu commented Jul 23, 2024

  • Parentheses: ( )
  • Brackets: [ ]
  • Braces: { }

All of them mean something different for bash ofc.
In bash's documentation they use the same terminology.

Leaving it as it is with bracket is confusing when going through the code and you start to wonder if we handle [ ], which we don't.

I guess you can name all of them brackets, but since we have support for both parentheses ( ) and braces { }, using the term in a general way is just not very clear.

@itislu itislu added the chore A routine task label Jul 23, 2024
@itislu itislu self-assigned this Jul 23, 2024
@itislu itislu moved this from Backlog to In progress in minishell (🌊rash) Jul 23, 2024
@itislu itislu linked a pull request Jul 23, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Done in minishell (🌊rash) Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A routine task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant