Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement validator payload retrieval #1194
Implement validator payload retrieval #1194
Changes from 8 commits
1026ea2
5bed3c9
d3ef6de
6449255
62f139c
f087501
634fb5f
185501f
db338cd
d905069
10d9455
b78dc9f
80bb5e6
e735165
a9b8267
2856bad
c37c7c7
f9e79b8
8be41aa
3f6f092
6c41942
09f2836
8007a09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way to derive this address using the service manager as a source of truth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Looking at reader.go,
BlsOperatorStateRetrieverAddr
andeigenDAServiceManagerHexAddr
are both required arguments. Though I'm not sure why that's the caseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we no longer require graph node for retrieving the DA node sockets. Instead, we can call a contract, https://github.com/Layr-Labs/eigenlayer-middleware/blob/fe5834371caed60c1d26ab62b5519b0cbdcb42fa/src/SocketRegistry.sol#L17, and use the mapping there to get the IP address, @0x0aa0 is that right?
mainnet: 0x5a3eD432f2De9645940333e4474bBAAB8cf64cf2
preprod: 0x1747ef24dbbb52cB06382d323f455D48dE1AC7fd
testnet: 0x25aFC8944f501545DDB7E7C4C8A0119965AAb166
But that requires changing this part, https://github.com/Layr-Labs/eigenda/blob/master/api/clients/retrieval_client.go#L122
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be able to retrieve onchain once all the operators have migrated over and set that in storage but this will not be instant so we will probably require the graph for a time while that migration takes place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0x0aa0 in V2, does operator inherit registration in V1, or have to register independently in V2? then it looks like migration is not a constraint for V2. But it forces us to support two version for retrieval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0x0aa0 Theoretically we should be able to make this change right away for this code, since operators will have to make the required updates to be able to use V2 anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this issue to address in the near future
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.