-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement distributed payload retrieval #1194
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
logger logging.Logger, | ||
distributedPayloadRetrieverConfig DistributedPayloadRetrieverConfig, | ||
ethConfig geth.EthClientConfig, | ||
thegraphConfig thegraph.Config, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we no longer require graph node for retrieving the DA node sockets. Instead, we can call a contract, https://github.com/Layr-Labs/eigenlayer-middleware/blob/fe5834371caed60c1d26ab62b5519b0cbdcb42fa/src/SocketRegistry.sol#L17, and use the mapping there to get the IP address, @0x0aa0 is that right?
mainnet: 0x5a3eD432f2De9645940333e4474bBAAB8cf64cf2
preprod: 0x1747ef24dbbb52cB06382d323f455D48dE1AC7fd
testnet: 0x25aFC8944f501545DDB7E7C4C8A0119965AAb166
But that requires changing this part, https://github.com/Layr-Labs/eigenda/blob/master/api/clients/retrieval_client.go#L122
continue | ||
} | ||
if !valid { | ||
pr.logger.Warn("cert is invalid", "blobKey", blobKey.Hex(), "quorumID", quorumID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would commitment is inconsistent be more concrete? invalid cert might mean wrong signature
continue | ||
} | ||
if !valid { | ||
pr.log.Warn("cert is invalid", "blobKey", blobKey.Hex(), "relayKey", relayKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"commitments are different" is more descriptive
Why are these changes needed?
GetBlob
method. Specifically, the previous method signature required access to aBlobHeader
, which cannot be constructed by a client, since they do not have the payment data.Checks