Fix for installing Wakhan from source #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to install the package using
pip install .it fails. However, addingsrc.hapcorrect.srcfixes this.I am pretty unfamiliar with how python packages work so please confirm this is actually supposed to be specified in this way.
Fixes: #13
Edit:
Some additional information why I wanted to install from source.
I was planning to add the package to bioconda-recipes, so that it will also be hosted on bioconda and automatically generate a docker+singularity image for it, for easier use in future pipelines. But then I realized the tool was failing the source installation.