Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for S3 as a remote filesystem #2676

Merged
merged 16 commits into from
Jan 27, 2025
Merged

Add support for S3 as a remote filesystem #2676

merged 16 commits into from
Jan 27, 2025

Conversation

zackgalbreath
Copy link
Contributor

No description provided.

@zackgalbreath zackgalbreath marked this pull request as draft January 23, 2025 16:19
@zackgalbreath zackgalbreath force-pushed the remote_filesystem branch 6 times, most recently from a7c3236 to f3c2a87 Compare January 23, 2025 20:32
@zackgalbreath zackgalbreath marked this pull request as ready for review January 23, 2025 21:28
@zackgalbreath
Copy link
Contributor Author

Note that we'll need to update the names of the required status checks if we accept the current state of my GitHub Actions changes.

williamjallen
williamjallen requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an initial round of big-picture comments. I'll probably have more detailed implementation comments once these are resolved.

app/Http/Controllers/BuildController.php Show resolved Hide resolved
app/cdash/include/common.php Show resolved Hide resolved
app/cdash/include/common.php Outdated Show resolved Hide resolved
app/cdash/tests/test_donehandler.php Show resolved Hide resolved
app/cdash/xml_handlers/abstract_xml_handler.php Outdated Show resolved Hide resolved
config/filesystems.php Show resolved Hide resolved
@williamjallen williamjallen added this to the v3.8 milestone Jan 24, 2025
@zackgalbreath
Add AWS S3 Adapter to Composer dependencies
1005703
@zackgalbreath
Update s3 filesystem config to match stock Laravel 10
5f50573
@zackgalbreath
Update submission process to better support remote filesystems
279464f 
Remove use of md5_file() and update call sites of Storage::path()
@zackgalbreath
Update XML validation to support remote filesystems
8a2782b
@zackgalbreath
Update uploaded files to support remote filesystems
d5dec83
@zackgalbreath
Update non-XML handlers to support remote filesystems
e2486be
@zackgalbreath
Update Done.xml handlers to support remote filesystems
a943947
@zackgalbreath
Update docker compose to test remote storage
b626cae
@zackgalbreath
Update GitHub Actions to test remote storage
501647e
@zackgalbreath
extract_tar: throw exception rather than returning empty string
7ad6cdd
@zackgalbreath
Delete tmp file in test_uploadfile
014e230
@zackgalbreath
Add comment defining required behavior for build_file()
1e90dbd
@zackgalbreath
Throw exceptions rather than return errors in AbstractXmlHandler::val…
38ffcfe 
…idate
@zackgalbreath
Regenerate phpstan-baseline.neon
6613cae
williamjallen
williamjallen reviewed Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor comment to resolve and then this should be good to go.

app/cdash/include/common.php Outdated Show resolved Hide resolved
@williamjallen
Copy link
Collaborator

williamjallen commented Jan 27, 2025 •
edited
Loading

Required checks have been updated. Leaving final merge for @zackgalbreath.

@zackgalbreath zackgalbreath added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit 88c87dc Jan 27, 2025
7 checks passed
@williamjallen williamjallen deleted the remote_filesystem branch January 27, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamjallen williamjallen williamjallen approved these changes

@josephsnyder josephsnyder Awaiting requested review from josephsnyder

Assignees
No one assigned
Labels
release notes: features
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@zackgalbreath @williamjallen