Skip to content

Commit

Permalink
Disable RemoteWorkers test when using s3 storage
Browse files Browse the repository at this point in the history
  • Loading branch information
zackgalbreath committed Jan 27, 2025
1 parent a86ae23 commit 57009cc
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
env:
SITENAME: GitHub Actions
BASE_IMAGE: ${{matrix.base-image}}
STORAGE_TYPE: ${{matrix.storage}}
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ctest_driver_script.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ ctest_empty_binary_directory("${CTEST_BINARY_DIRECTORY}")
set(cfg_options
"-DCDASH_DIR_NAME="
"-DCDASH_SERVER=localhost:8080"
"-DCDASH_STORAGE_TYPE=${STORAGE_TYPE}"
)

# Backup .env file
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/submit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ submit_type="${submit_type:-Experimental}"

site="${SITENAME:-$(hostname)}"

storage_type="${STORAGE_TYPE:-local}"

echo "site=$site"
echo "database=$database"
echo "ctest_driver=$ctest_driver"
Expand All @@ -40,6 +42,7 @@ docker exec cdash bash -c "\
--schedule-random \
-DSITENAME=\"${site}\" \
-DDATABASE=\"${database}\" \
-DSTORAGE_TYPE=\"${storage_type}\" \
-DSUBMIT_TYPE=\"${submit_type}\" \
-S \"${ctest_driver}\" \
"
3 changes: 3 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ configure_file(
# to configure the testing install
set(CDASH_SERVER localhost CACHE STRING "CDash testing server")
set(CDASH_IMAGE "$ENV{BASE_IMAGE}" CACHE STRING "Docker image name")
if(NOT DEFINED CDASH_STORAGE_TYPE)
set(CDASH_STORAGE_TYPE "local")
endif()

get_filename_component(CDASH_DIR_NAME_DEFAULT ${CDash_SOURCE_DIR} NAME)
set(CDASH_DIR_NAME "${CDASH_DIR_NAME_DEFAULT}" CACHE STRING "URL suffix. Ie 'http://<CDASH_SERVER>/<CDASH_DIR_NAME>'")
Expand Down
5 changes: 4 additions & 1 deletion app/cdash/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,10 @@ add_unit_test(/CDash/Messaging/Topic/TopicDecorator)
set_tests_properties(/CDash/Messaging/Topic/TopicDecorator PROPERTIES DEPENDS /CDash/XmlHandler/UpdateHandler)

add_laravel_test(/Feature/RemoteWorkers)
set_tests_properties(/Feature/RemoteWorkers PROPERTIES DEPENDS /CDash/XmlHandler/UpdateHandler)
set_tests_properties(/Feature/RemoteWorkers PROPERTIES
DEPENDS /CDash/XmlHandler/UpdateHandler
DISABLED "$<STREQUAL:${CDASH_STORAGE_TYPE},s3>"
)

add_laravel_test(/Feature/Jobs/NotifyExpiringAuthTokensTest)
set_tests_properties(/Feature/Jobs/NotifyExpiringAuthTokensTest PROPERTIES RUN_SERIAL TRUE)
Expand Down

0 comments on commit 57009cc

Please sign in to comment.