Fix issue where expected buffer-sizes buffer not bound to Metal compute encoder. #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te encoder. MVKComputeResourcesCommandEncoderState update buffer-size value before buffer bindings are encoded into Metal and are no longer marked as dirty.
|
We've been seeing issues running Dark Souls III with CrossOver on Mojave, and I traced them back to this change. Specifically, we were seeing a weird effect where a multicolored overlay would make the game nigh unplayable. I'm not sure why this change causes it. Further, we've only seen this on Mojave; we don't see it on Catalina or Big Sur. Unfortunately, because Mojave doesn't support GPU capture without Xcode, I haven't been able to analyze a GPU trace to figure out why this change causes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKComputeResourcesCommandEncoderStateupdate buffer-size value before bufferbindings are encoded into Metal and are no longer marked as dirty.
Fixes issue #959.