Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: remove the old eddy current support #534

Closed
wants to merge 1 commit into from
Closed

Conversation

rogerlz
Copy link
Contributor

@rogerlz rogerlz commented Jan 13, 2025

The existing support for eddy current sensors is pretty old and unmaintained.

as stated here, we aren't currently working on it, but we will definitely review a good implementation.

@rogerlz rogerlz requested a review from a team as a code owner January 13, 2025 11:49
@HeavilyModdedEnder3
Copy link

Removing it without replacing it will break all BTT Eddy user's Kalico installments (if they update, which of course they will)

@rogerlz
Copy link
Contributor Author

rogerlz commented Jan 16, 2025

Removing it without replacing it will break all BTT Eddy user's Kalico installments (if they update, which of course they will)

Yes, thats expected. Due to the how old the code is, I believe there is no one running Kalico and BTT Eddy. And if there is, I would prefer them to know that is it outdated, unsupported and potentially unsafe.

@Bradford1040
Copy link

Bradford1040 commented Jan 26, 2025

rogerlz I am a Mercury one owner and use BTT EDDY and had it working with Danger Klipper, before the switch, I pulled my rig apart as I was reprinting everything and building a tradrack, got a little overwhelmed so have taken a bit of a break on that machine, but I do believe there are many others that are using the EDDY with Kalico/Danger.

I was just looking around at different updates tonight, and noticed your comment, just bringing up that there are people that use Kalico that are not active on github nor watching to see what is truly happening, they just hit update when they see they have one.

No real reason to reply to me, I was just voicing an opinion about things, I am able to get what I need to work working via my own fork, but others don't and having EDDY working with Kalico IMHO is important to those that can't afford say a Beacon

@rogerlz
Copy link
Contributor Author

rogerlz commented Feb 1, 2025

rogerlz I am a Mercury one owner and use BTT EDDY and had it working with Danger Klipper, before the switch, I pulled my rig apart as I was reprinting everything and building a tradrack, got a little overwhelmed so have taken a bit of a break on that machine, but I do believe there are many others that are using the EDDY with Kalico/Danger.

I was just looking around at different updates tonight, and noticed your comment, just bringing up that there are people that use Kalico that are not active on github nor watching to see what is truly happening, they just hit update when they see they have one.

No real reason to reply to me, I was just voicing an opinion about things, I am able to get what I need to work working via my own fork, but others don't and having EDDY working with Kalico IMHO is important to those that can't afford say a Beacon

thanks for the feedback. I will keep it and will add a disclaimer to the documentation that it is outdated and should be used with caution.

@rogerlz rogerlz closed this Feb 1, 2025
@rogerlz rogerlz deleted the eddycleanup branch February 1, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants