Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default mapping for :LeanRestartFile and related tips #357

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

utensil
Copy link
Contributor

@utensil utensil commented Oct 22, 2024

Zulip

  • Add a default mapping for :LeanRestartFile
    • stylua
    • test
  • Add related tips, restart file, restart server
    • review wordings

@Julian
Copy link
Owner

Julian commented Oct 22, 2024

Thanks! The style warning is markdownlint being silly, we only care about GitHub's parser. The wordings actually look fine to me too -- if you do care to add a test it should be pretty trivial to do so although we don't actually test all the mappings we set really currently, we just pick some single one and make sure it's properly mapped -- so I'm happy to merge this as-is and add a linter exception -- if you do have any other suggestions or improvements on this or anything though they're always welcome!

@Julian Julian merged commit 9a28f00 into Julian:main Oct 22, 2024
5 of 6 checks passed
@utensil
Copy link
Contributor Author

utensil commented Oct 22, 2024

Thanks, I'll try to figure out how to set up the test tomorrow, and add the test.

@utensil
Copy link
Contributor Author

utensil commented Oct 22, 2024

Updated and tested locally from nvim, it seems to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants