Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for LeanRestartFile mapping #358

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

utensil
Copy link
Contributor

@utensil utensil commented Oct 23, 2024

This is the test for #357 . It passes in the sense that

just retest spec/mappings_spec.lua

returns 0, and I can manage to fail it too.

But it's mostly a dummy test, checking the key mapping is set, but I don't really know how to check if it can restart file.

So, feel free to close without merging.

Also, I can't pass all existing tests locally, some of them are failing without modifications, the log file is attached.

just-test.log

@Julian
Copy link
Owner

Julian commented Oct 23, 2024

Thanks! Yeah writing a test for the actual restart functionality is a bit trickier, though should still be doable, it's been on my list of "known missing tests". No harm merging this I suppose.

Also, I can't pass all existing tests locally, some of them are failing without modifications, the log file is attached.

Are you on nightly? There's some flakiness in the tests which seems to only manifest on nightly. If you run the suite a few times, does it pass any of them?

@Julian Julian merged commit 9d1c04f into Julian:main Oct 23, 2024
6 checks passed
@utensil
Copy link
Contributor Author

utensil commented Oct 23, 2024

Not really, I'm on nvim v 0.10.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants