Update for KNITRO.jl v0.14.0 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontoison
approved these changes
Nov 29, 2023
|
Thanks Oscar! I will merge it when the version 0.14 of KNITRO.jl will be released. |
|
Can you re-start CI? IT should work now |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 77.73% 76.30% -1.43%
==========================================
Files 4 4
Lines 265 287 +22
==========================================
+ Hits 206 219 +13
- Misses 59 68 +9 ☔ View full report in Codecov by Sentry. |
|
How do these tests run if you have the license in the other PR? |
|
Nice nice nice. This seems like the tests are passing with the new version. |
We also have self-hosted builds with a dedicated KNITRO licence for the cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been simplifying the C API to KNITRO.jl: jump-dev/KNITRO.jl#267. The main change is to align everything with the underlying C API of Knitro and removing the Julia-specific functions.
The downside is that it introduces a few breaking changes. This PR fixes the tests.