Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use the licence sent by Artelys #118

Merged
merged 2 commits into from
Nov 29, 2023
Merged

[CI] Use the licence sent by Artelys #118

merged 2 commits into from
Nov 29, 2023

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Nov 29, 2023

It will help to test #117.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b044be8) 76.30% compared to head (2e6a823) 76.30%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   76.30%   76.30%           
=======================================
  Files           4        4           
  Lines         287      287           
=======================================
  Hits          219      219           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deps/build.jl Outdated Show resolved Hide resolved
@amontoison
Copy link
Member Author

amontoison commented Nov 29, 2023

I have the following error:

ERROR: LoadError: could not load library "/home/runner/.julia/packages/KNITRO/RJPC2/deps/libknitro.so"
libiomp5.so: cannot open shared object file: No such file or directory

Update: You probably fixed it with the new release of KNITRO.jl.

@odow
Copy link
Contributor

odow commented Nov 29, 2023

I don't think so. what happens if you add the environment variables to the test stage, not just buildpkg.

- uses: julia-actions/julia-runtest@v1
env:
SECRET_KNITRO_URL: ${{ secrets.SECRET_KNITRO_URL }}
SECRET_KNITRO_LIBIOMP5: ${{ secrets.SECRET_KNITRO_LIBIOMP5 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, but I guess there is another call to Pkg.build, and this throws away the work we did in the previous step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed 🎉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I guess that means you can stop using your cluster for the tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only on Linux, I can't use the "CI" licence for Mac.

@amontoison amontoison merged commit 92b3d10 into main Nov 29, 2023
10 checks passed
@amontoison amontoison deleted the update_ci branch November 29, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants