Update NLPModelsJuMP for MathOptInterface #38

amontoison · 2020-02-18T20:53:08Z

close #22
close #41

abelsiqueira

Very small changes. I haven't checked the API changes, I'm trusting consistency here.

Project.toml

docs/Project.toml

abelsiqueira · 2020-02-18T21:09:32Z

docs/make.jl

@@ -2,6 +2,7 @@ using Documenter, NLPModelsJuMP

 makedocs(
  modules = [NLPModelsJuMP],
+  checkdocs = :exports,


What does this do?

Without checkdocs = :exports, documenter says that the documentation of replace! is missing. And with strict = true the build of the documentation is failing.

coveralls · 2020-02-18T21:24:56Z

Coverage increased (+23.3%) to 100.0% when pulling ebe5356 on amontoison:moi into 2bca1e9 on JuliaSmoothOptimizers:master.

dpo

That's a lot of changes at once. Here's a first round of comments. Many thanks for all this!!!

docs/src/tutorial.md

dpo · 2020-02-18T23:42:22Z

src/NLPModelsJuMP.jl

@@ -1,9 +1,7 @@
-__precompile__()


Does precompilation fail?

I thought that precompilation was done by default with the last versions of Julia, is it not the case?

src/moi_nlp_model.jl

amontoison · 2020-03-02T06:00:13Z

@abelsiqueira @dpo
I updated MathOptNLPModel for NLPModel v0.12 :

jac and hess functions removed
jprod!(nlp, x, v, Jv) and jtprod!(nlp, x, v, Jtv) updated
hess_structure! and jac_structure! modified because jrows, jcols, jvals, hrows, hcols and hvals are not stored anymore in the model
jprod!(nlp, x, rows, cols, v, Jv) and jtprod!(nlp, x, rows, cols, v, Jtv) functions added
:ExprGraph removed (should avoid OufOfMemory error on power OptimizationProblems.jl#38)

I also updated MathOptNLSModel :

jac_residual, jac, hess_residual, hess and jth_hess_residuals functions removed
hess_structure_residual!, jac_structure_residual!, hess_structure! and jac_structure! modified because Fjrows, Fjcols, Fjvals, Fhrows, Fhcols, Fhvals, cjrows, cjcols, cjvals, chrows, chcols, chvals are not stored anymore in the model
jprod_residual!(nlp, x, v, Jv), jtprod_residual!(nlp, x, v, Jtv), jprod!(nlp, x, v, Jv) and jtprod!(nlp, x, v, Jtv) updated
:ExprGraph only called when required

Do I forget something or not?

abelsiqueira

I think that's it.

abelsiqueira · 2020-03-08T13:01:45Z

Project.toml

-MathProgBase = "0.7.6"
-NLPModels = "0.11"
-julia = "^1.0.0"
+JuMP = "0.21"


Doesn't it work with JuMP > 0.19?

It works with JuMP 0.19, 0.20 and 0.21. But you asked me to leave only one version of JuMP.

Sorry, I wasn't clear. I meant on the docs/Project.toml to just leave the latest version. The main Project.toml should handle more versions, to avoid conflicts.

abelsiqueira · 2020-03-08T13:37:34Z

.cirrus.yml

@@ -4,9 +4,6 @@ task:
  name: FreeBSD
  env:
    matrix:
-      - JULIA_VERSION: 1.0
-      - JULIA_VERSION: 1.1
-      - JULIA_VERSION: 1.2
      - JULIA_VERSION: 1.3


You can also add 1.4 now.

dpo

Looks great, thank you!

We need a new release of NLPModels first, right? @abelsiqueira

src/moi_nlp_model.jl

src/moi_nls_model.jl

abelsiqueira · 2020-03-08T17:21:35Z

Looks great, thank you!

We need a new release of NLPModels first, right? @abelsiqueira

Yes, but Alexis asked for JuliaSmoothOptimizers/NLPModels.jl#257 before 0.12.0

abelsiqueira · 2020-03-08T17:32:52Z

JuliaRegistries/General#10700

dpo · 2020-03-08T21:10:19Z

Hooray!!!

amontoison mentioned this pull request Feb 18, 2020

Update NLPModelsJuMP for MathOptInterface #37

Closed

abelsiqueira requested changes Feb 18, 2020

View reviewed changes

dpo requested changes Feb 19, 2020

View reviewed changes

amontoison force-pushed the moi branch from 0697dbd to 09da788 Compare February 20, 2020 02:55

dpo reviewed Feb 21, 2020

View reviewed changes

src/moi_nlp_model.jl Outdated Show resolved Hide resolved

amontoison added 8 commits March 2, 2020 00:48

MathOptNLPModel and MathOptNLSModel

ba2277b

Update Travis

e4fc552

Update Project.toml

d369b2b

Optimize MathOptNLPModel

68b022a

Optimize MathOptNLSModel

b67890f

Add a section about NLSProblems in the documentation

0d869ca

Update MathOptNLSModel for 32 bits OS

c8fa041

Add a .gitignore

3a3b272

amontoison force-pushed the moi branch from 02e5e8c to b90d5b9 Compare March 2, 2020 05:50

amontoison added 3 commits March 2, 2020 12:01

Drop julia < 1.3

6f4e186

Update MathOptNLPModel for NLPModels v0.12

d042a50

Update MathOptNLSModel for NLPModels v0.12

4b53aa9

amontoison force-pushed the moi branch from b90d5b9 to 4b53aa9 Compare March 2, 2020 17:01

dpo requested a review from abelsiqueira March 2, 2020 17:09

abelsiqueira requested changes Mar 8, 2020

View reviewed changes

dpo requested changes Mar 8, 2020

View reviewed changes

src/moi_nlp_model.jl Outdated Show resolved Hide resolved

src/moi_nls_model.jl Outdated Show resolved Hide resolved

src/moi_nls_model.jl Outdated Show resolved Hide resolved

amontoison added 2 commits March 8, 2020 11:38

ex -> con

bdaf11b

Add Julia 1.4

064533c

amontoison force-pushed the moi branch from def8764 to 064533c Compare March 8, 2020 15:43

Allow all versions of JuMP that work with MOI

ebe5356

amontoison mentioned this pull request Mar 8, 2020

Update NLSProblems for NLPModelJuMP 0.6 JuliaSmoothOptimizers/NLSProblems.jl#37

Merged

abelsiqueira approved these changes Mar 8, 2020

View reviewed changes

dpo merged commit e1ec5e9 into JuliaSmoothOptimizers:master Mar 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update NLPModelsJuMP for MathOptInterface #38

Update NLPModelsJuMP for MathOptInterface #38

amontoison commented Feb 18, 2020 •

edited

Loading

abelsiqueira left a comment

abelsiqueira Feb 18, 2020

amontoison Feb 18, 2020 •

edited

Loading

coveralls commented Feb 18, 2020 •

edited

Loading

dpo left a comment

dpo Feb 18, 2020

amontoison Feb 19, 2020

amontoison commented Mar 2, 2020 •

edited

Loading

abelsiqueira left a comment

abelsiqueira Mar 8, 2020

amontoison Mar 8, 2020

abelsiqueira Mar 8, 2020

abelsiqueira Mar 8, 2020

dpo left a comment

abelsiqueira commented Mar 8, 2020

abelsiqueira commented Mar 8, 2020

dpo commented Mar 8, 2020

Update NLPModelsJuMP for MathOptInterface #38

Update NLPModelsJuMP for MathOptInterface #38

Conversation

amontoison commented Feb 18, 2020 • edited Loading

abelsiqueira left a comment

Choose a reason for hiding this comment

abelsiqueira Feb 18, 2020

Choose a reason for hiding this comment

amontoison Feb 18, 2020 • edited Loading

Choose a reason for hiding this comment

coveralls commented Feb 18, 2020 • edited Loading

dpo left a comment

Choose a reason for hiding this comment

dpo Feb 18, 2020

Choose a reason for hiding this comment

amontoison Feb 19, 2020

Choose a reason for hiding this comment

amontoison commented Mar 2, 2020 • edited Loading

abelsiqueira left a comment

Choose a reason for hiding this comment

abelsiqueira Mar 8, 2020

Choose a reason for hiding this comment

amontoison Mar 8, 2020

Choose a reason for hiding this comment

abelsiqueira Mar 8, 2020

Choose a reason for hiding this comment

abelsiqueira Mar 8, 2020

Choose a reason for hiding this comment

dpo left a comment

Choose a reason for hiding this comment

abelsiqueira commented Mar 8, 2020

abelsiqueira commented Mar 8, 2020

dpo commented Mar 8, 2020

amontoison commented Feb 18, 2020 •

edited

Loading

amontoison Feb 18, 2020 •

edited

Loading

coveralls commented Feb 18, 2020 •

edited

Loading

amontoison commented Mar 2, 2020 •

edited

Loading