Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NLSProblems for NLPModelJuMP 0.6 #37

Merged
merged 4 commits into from
Mar 9, 2020

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Feb 18, 2020

Update the package for NLPModelsJuMP 0.6 / JuMP 0.21 and NLPModel 0.12.

@amontoison amontoison marked this pull request as ready for review February 18, 2020 23:00
src/hs13.jl Outdated Show resolved Hide resolved
src/tp268.jl Show resolved Hide resolved
@amontoison
Copy link
Member Author

One model (mgh35) can't be updated with JuMP ≥ 0.19. Should I remove it?
https://discourse.julialang.org/t/nlexpression-with-jump-0-21/34859/2

@abelsiqueira
Copy link
Member

I'm fine with removing it.

@amontoison
Copy link
Member Author

Thanks Abel, I removed mgh35 problem.

@dpo
Copy link
Member

dpo commented Feb 20, 2020

Does it mean it's impossible to implement that problem with JuMP?

@amontoison
Copy link
Member Author

amontoison commented Feb 20, 2020

We can implement that problem with JuMP but we cannot use NLexpression. We need to create the expression ourself and give the Expr to set_NL_objective and / or add_NL_constraint.

In our specific case, we explicitly need the NLexpression for building an MathOptNLSModel because we use them for the constraints of the Fmodel and the objective of the cmodel.

@amontoison amontoison changed the title Update NLSProblems for MOI / JuMP ≥ 0.21 Update NLSProblems for NLPModelJuMP 0.6 Mar 8, 2020
@amontoison
Copy link
Member Author

Close / reopen this pull request when JuliaSmoothOptimizers/NLPModelsJuMP.jl#38 is merged.

@dpo dpo closed this Mar 9, 2020
@dpo dpo reopened this Mar 9, 2020
@amontoison amontoison closed this Mar 9, 2020
@amontoison amontoison reopened this Mar 9, 2020
@dpo dpo merged commit 13047b2 into JuliaSmoothOptimizers:master Mar 9, 2020
@dpo
Copy link
Member

dpo commented Mar 9, 2020

Thank you.

@dpo
Copy link
Member

dpo commented Mar 9, 2020

Note for the future: that's not the right way to trigger builds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants