Make isassigned work with tuples
#30028
Open
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is going to work, this is how it needs to work but I'm just wondering if this is a good idea for tuples. Requesting @JeffBezanson's input on the design aspect... |
|
seems reasonable to me... Let's see if I can rebase this 5 years and have it still pass tests :) |
This commit adds a method `isassigned(v::Tuple, i::Integer)` which makes that function work on `Tuple`s, the same way it does on `Vector`s. (Since a `Tuple` cannot be created without being assigned, all that is left is to check that the index is within bounds.) This makes it easier to write generic code that works on both `Vector`s and `Tuple`s.
oscardssmith
force-pushed
the
isassigned
branch
from
b311411 to
a26c418
Compare
|
🤷 Might as well I guess. |
JeffBezanson
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method
isassigned(v::Tuple, i::Integer)which makes that function work onTuples in exactly the same way that it does onVectors. (Since aTuplecannot be created without being assigned, all that is left is to check that the index is within bounds.)This makes it easier to write generic code that works on both
Vectors andTuples.