Remove the Fixed Shaped Iterator #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 71.22% 72.94% +1.72%
==========================================
Files 19 19
Lines 688 669 -19
==========================================
- Hits 490 488 -2
+ Misses 198 181 -17 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ReubenJ
force-pushed
the
remove_fixed_shape_iterator
branch
2 times, most recently
from
2ed4ffc to
6e9c8f9
Compare
Now always using the uniform solver in the top down iterator. Removed unused heuristic_leftmost_fixed_shaped_hole Co-authored-by: Issa Hanou <[email protected]>
Co-authored-by: Issa Hanou <[email protected]>
ReubenJ
force-pushed
the
remove_fixed_shape_iterator
branch
from
6e9c8f9 to
90a8837
Compare
ReubenJ
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110