remove use_uniformsolver parameter from GenericSolver #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 75.62% 75.84% +0.21%
==========================================
Files 31 31
Lines 1395 1395
==========================================
+ Hits 1055 1058 +3
+ Misses 340 337 -3 ☔ View full report in Codecov by Sentry. |
ReubenJ
requested changes
Feb 18, 2025
ReubenJ
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the FixedShapeItorator and having the TopDownIterator always use the UniformSolver. This parameter was not used elsewhere.
Together with HerbSearch.jl PR: Herb-AI/HerbSearch.jl#135
Closes Issue: Herb-AI/HerbSearch.jl#110