-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to changes from GaloisInc/cryptol#1751, GaloisInc/cryptol#1526, and friends #2174
Conversation
ac8ce90
to
9b0bf14
Compare
I've confirmed that things break once the
|
The projects code I inherited had some logic in its to give nicer names to Main modules. I don't know why it was written to assume it wouldn't be called on Main. I'll have to read through the code to work out what it's doing. |
42145b1
to
409a96d
Compare
GaloisInc/cryptol#1751 removed the width field from word values, which requires mechanical changes on the `cryptol-saw-core` side to make it build. This bumps the `cryptol` submodule and makes the corresponding code changes.
…Inc/cryptol#1783, and GaloisInc/cryptol#1791 This is a collection of `cryptol` submodule bumps that is squashed together in order to ensure that the SAW CI continues to pass with this commit: * GaloisInc/cryptol#1783 bumps Cryptol's lower version bounds on `simple-smt` to `>=0.9.8`, which requires updating SAW's `cabal.GHC-*.config` files accordingly. * GaloisInc/cryptol#1526 is brought along for the ride as part of this bump, but this will not pass SAW's integration tests without also including the bugfix from GaloisInc/cryptol#1791. As a result, I've also included GaloisInc/cryptol#1791. GaloisInc/cryptol#1791 is latest of the three patchsets, so I have bumped the `cryptol` submodule to point to the merge commit from that PR.
409a96d
to
68a404c
Compare
cryptol-saw-core
to changes from GaloisInc/cryptol#1751cryptol-saw-core
to changes from GaloisInc/cryptol#1751, GaloisInc/cryptol#1526, and friends
Thanks to @glguy's heroism, I was able to make the CI pass by including the changes from GaloisInc/cryptol#1791. I've included this and cleaned up the commit history. This should now be ready for review. Once this lands, I'll base #2173 (which also requires bumping the Cryptol submodule) on top of it. |
cryptol-saw-core
to changes from GaloisInc/cryptol#1751, GaloisInc/cryptol#1526, and friendsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly simple for how hard it blew up before...
(actually n/m, missed that it had to get fixed upstream first)
GaloisInc/cryptol#1751 removed the width field from word values, which requires mechanical changes on the
cryptol-saw-core
side to make it build. This bumps thecryptol
submodule and makes the corresponding code changes.GaloisInc/cryptol#1526 requires updating the freeze files used in the CI files to make them able to download
simple-smt-0.9.8
.