Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitwuzla support #2173

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add Bitwuzla support #2173

merged 2 commits into from
Jan 24, 2025

Conversation

RyanGlScott
Copy link
Contributor

@RyanGlScott RyanGlScott commented Jan 9, 2025

Bumps the crucible submodule to bring in Bitwuzla-related changes from GaloisInc/crucible#1270.

Fixes #2172.

@RyanGlScott
Copy link
Contributor Author

RyanGlScott commented Jan 9, 2025

Hm, the Cryptol submodule update appears to have broken several of the test cases in the test suite. I'll mark this PR as a draft for now and debug the test suite failures in a separate PR (#2174) that does nothing but bump the Cryptol submodule.

@RyanGlScott RyanGlScott marked this pull request as draft January 9, 2025 16:42
Copy link
Contributor

@sauclovian-g sauclovian-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the stuff actually in here seems fine, so once we fix the version bump problems it should be fine to merge this.

@RyanGlScott
Copy link
Contributor Author

I've rebased on top of the changes from #2174, which should fix the test suite issues observed in #2173 (comment).

@RyanGlScott RyanGlScott marked this pull request as ready for review January 24, 2025 12:58
Bumps the `crucible` submodule to bring in Bitwuzla-related changes from
GaloisInc/crucible#1270.

Fixes #2172.
@RyanGlScott RyanGlScott merged commit 24c180f into master Jan 24, 2025
32 of 34 checks passed
@RyanGlScott RyanGlScott deleted the bitwuzla branch January 24, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Bitwuzla
2 participants