Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ConnectScreen.BLOCKED_HOST_TEXT -> ConnectScreen.UNKNOWN_HOST_TEXT #3781

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Correct ConnectScreen.BLOCKED_HOST_TEXT -> ConnectScreen.UNKNOWN_HOST_TEXT #3781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f9b39
Correct ConnectScreen.UNKNOWN_HOST_TEXT
NoahvdAa Feb 5, 2024
e120d05
Merge branch '24w06a' into patch-1
modmuss50 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mappings/net/minecraft/client/gui/screen/multiplayer/ConnectScreen.mapping
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ CLASS net/minecraft/class_412 net/minecraft/client/gui/screen/multiplayer/Connec
FIELD field_2412 parent Lnet/minecraft/class_437;
FIELD field_2413 status Lnet/minecraft/class_2561;
FIELD field_32238 NARRATOR_INTERVAL J
FIELD field_33736 BLOCKED_HOST_TEXT Lnet/minecraft/class_2561;
FIELD field_33736 UNKNOWN_HOST_TEXT Lnet/minecraft/class_2561;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue to name this UNKNOWN_BLOCKED_HOST_TEXT

Copy link
Contributor

@haykam821 haykam821 Feb 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think UNKNOWN_HOST_TEXT is a good name. The text is the following, which translates as 'Unknown host':

public static final Text BLOCKED_HOST_TEXT = Text.translatable("disconnect.genericReason", Text.translatable("disconnect.unknownHost"));

FIELD field_44548 failureErrorMessage Lnet/minecraft/class_2561;
FIELD field_44970 ABORTED_TEXT Lnet/minecraft/class_2561;
FIELD field_44971 future Lio/netty/channel/ChannelFuture;
Expand Down