Correct ConnectScreen.BLOCKED_HOST_TEXT -> ConnectScreen.UNKNOWN_HOST_TEXT #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zOnlyKroks
suggested changes
Feb 8, 2024
| @@ -13,7 +13,7 @@ CLASS net/minecraft/class_412 net/minecraft/client/gui/screen/multiplayer/Connec | |||
| FIELD field_2412 parent Lnet/minecraft/class_437; | |||
| FIELD field_2413 status Lnet/minecraft/class_2561; | |||
| FIELD field_32238 NARRATOR_INTERVAL J | |||
| FIELD field_33736 BLOCKED_HOST_TEXT Lnet/minecraft/class_2561; | |||
| FIELD field_33736 UNKNOWN_HOST_TEXT Lnet/minecraft/class_2561; | |||
There was a problem hiding this comment.
I would argue to name this UNKNOWN_BLOCKED_HOST_TEXT
There was a problem hiding this comment.
I think UNKNOWN_HOST_TEXT is a good name. The text is the following, which translates as 'Unknown host':
public static final Text BLOCKED_HOST_TEXT = Text.translatable("disconnect.genericReason", Text.translatable("disconnect.unknownHost"));
haykam821
added
the
update-base
|
🚀 Target branch has been updated to 24w06a |
|
🚨 Unable to automatically update branch with the latest changes |
github-actions
bot
added
snapshot
modmuss50
added
the
update-base
|
🎉 Target branch is already set to 24w06a |
|
🚨 Unable to automatically update branch with the latest changes |
github-actions
bot
removed
the
update-base
|
Im not sure why its failing to merge, ive done it manually. |
Shnupbups
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this text component is used when a server has been blocked by Mojang, it's also shown when no IP addresses can be found for the specified hostname, as can be shown in this excerpt from the MultiplayerServerListPinger class:
The default resolver will return an empty optional both when the server is blocked and when no A and AAAA records are found.