Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scalar integer code to calculate PF #3545

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

alyssarosenzweig
Copy link
Collaborator

  • This is probably fewer cycles for the same # of instructions (?). And thanks to FPU shenanigans, PF calculation isn't completely legacy 🙃
  • Lets us fold in an invert to save an instruction in setp 🤡

Signed-off-by: Alyssa Rosenzweig <[email protected]>
based on clang's __builtin_parity

Signed-off-by: Alyssa Rosenzweig <[email protected]>
with xorn

Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I love the improvement.
fmov+cnt+umov is quite spicy with both fmov and umov having terrible throughput.
Meanwhile we have 4-8 integer pipelines that can all consume eor/eon.

@alyssarosenzweig alyssarosenzweig merged commit bd0b5ec into FEX-Emu:main Apr 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants