2048 avoid connecting to 3rd party apis from tests #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that in the validation lc tests instead of using external apis
… deployments for testing
alysiahuggins
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
alysiahuggins
removed request for
philippecamacho,
nomaxg,
jbearer,
ImJeremyHe and
tbro
imabdulbasit
requested changes
Sep 26, 2024
imabdulbasit
approved these changes
Oct 10, 2024
imabdulbasit
deleted the
2048-avoid-connecting-to-3rd-party-apis-from-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2048
This PR:
Key places to review:
How to test this PR:
cargo test genesis --all-featurescargo test service --all-features