Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid connecting to 3rd party APIs from tests #2048

Closed
sveitser opened this issue Sep 22, 2024 · 0 comments · Fixed by #2056
Closed

Avoid connecting to 3rd party APIs from tests #2048

sveitser opened this issue Sep 22, 2024 · 0 comments · Fixed by #2056
Assignees
@alysiahuggins
Labels
sequencer tech debt

Comments

@sveitser
Copy link
Collaborator

We currently have tests that run against sepolia:

espresso-sequencer/hotshot-state-prover/src/service.rs

Line 727 in 51bef3b

provider: Url::from_str("https://ethereum-sepolia.publicnode.com")

This should use a local RPC instead.

Connecting to external services breaks test isolation:

1 The services may disappear, be unavailable.
2. We may get rate limited. Especially on the CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alysiahuggins alysiahuggins

Labels
sequencer tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2048 avoid connecting to 3rd party apis from tests EspressoSystems/espresso-sequencer
2 participants
@sveitser @alysiahuggins