Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): Dashboard tests #1124

Merged
merged 16 commits into from
Feb 5, 2025
Merged

feat(test): Dashboard tests #1124

merged 16 commits into from
Feb 5, 2025

Conversation

thetif
Copy link
Collaborator

@thetif thetif commented Feb 5, 2025

🎫 Linked Ticket

OY2-29687

💬 Description / Notes

Tests for Dashboard

🛠 Changes

  • refactored tests for SpasList and WaiversList to remove duplication
  • added tests for Dashboard
  • fixed typo

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 92.15% (🎯 90%)
⬆️ +0.44%
4403 / 4778
🟢 Statements 91.66% (🎯 90%)
⬆️ +0.44%
4796 / 5232
🟢 Functions 86.53% (🎯 85%)
⬆️ +0.71%
1343 / 1552
🟢 Branches 80.83% (🎯 80%)
⬆️ +0.61%
2324 / 2875
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/components/ErrorAlert/index.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
react-app/src/features/dashboard/index.tsx 65%
⬆️ +43.95%
69.23%
⬆️ +69.23%
75%
⬆️ +62.50%
65%
⬆️ +43.95%
23-35
Generated in workflow #1986 for commit 19b992f by the Vitest Coverage Report Action

@thetif thetif temporarily deployed to test-dashboard-2 February 5, 2025 19:20 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-2-kibana February 5, 2025 19:20 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-2-app February 5, 2025 19:20 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-2 February 5, 2025 19:20 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-2 February 5, 2025 19:20 — with GitHub Actions Inactive
@thetif thetif temporarily deployed to test-dashboard-2 February 5, 2025 19:34 — with GitHub Actions Inactive
Copy link
Collaborator

@13bfrancis 13bfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thetif thetif merged commit affc73b into main Feb 5, 2025
15 checks passed
@thetif thetif deleted the test-dashboard-2 branch February 5, 2025 19:42
asharonbaltazar added a commit that referenced this pull request Feb 7, 2025
* feat(test): Dashboard tests (#1124)

* added test for Dashboard
* refactored tests for SpasList and WaiversList to remove code duplication
* misc clean up

* feat: initial restructure (#1102)

feat: complete reorg

feat: added new test id

fix: correct lint

fix: remove commented out files

fix: update snapshot

fix: remove e2e tests from coverage calc

fix: update path

* fix(idm-fix-01): start small (#1119)

* start small

* add ismemberof

* feat(ui): new favicon (#1129)

* chore: update favicon icons

* feat: add logic to `index.html` for dynamic favicon

* fix: move favicon files into the proper dir

* fix(test): removed test block on deploying (#1137)

* removed test block from deploy

* feat(test) legacy file coverage removal (#1131)

* feat(test) legacy file coverage removal

* update messed up value

* fix(withdraw-email): fix spelling on subject withdraw email line

---------

Co-authored-by: Tiffany Forkner <[email protected]>
Co-authored-by: Jon Schaffer <[email protected]>
Co-authored-by: 13bfrancis <[email protected]>
Co-authored-by: asharonbaltazar <[email protected]>
Co-authored-by: Thomas Walker <[email protected]>
Co-authored-by: James Dinh <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 7, 2025

🎉 This PR is included in version 1.5.0-val.126 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants