feat(test): Dashboard tests (#1124)

* added test for Dashboard * refactored tests for SpasList and WaiversList to remove code duplication * misc clean up
Enterprise-CMCS · Feb 5, 2025 · affc73b · affc73b
1 parent 89dba5b
commit affc73b
Show file tree

Hide file tree

Showing 11 changed files with 744 additions and 1,306 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -28,10 +28,24 @@ jobs:
               echo "ERROR:  Your branch name, $STAGE_NAME, is not a valid Serverless Framework stage name." && exit 1
           fi
 
+  test:
+    runs-on: ubuntu-20.04
+    needs:
+      - init
+    environment:
+      name: ${{ startsWith(github.ref_name, 'snyk-') && 'snyk' || github.ref_name }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - uses: ./.github/actions/setup
+      - name: Test
+        run: run test
+
   deploy:
     runs-on: ubuntu-20.04
     needs:
       - init
+      - test
     environment:
       name: ${{ startsWith(github.ref_name, 'snyk-') && 'snyk' || github.ref_name }}
     outputs:
@@ -96,19 +110,6 @@ jobs:
         run: |
           echo "Kibana URL: ${{ needs.deploy.outputs.kibana-url }}"
 
-  test:
-    runs-on: ubuntu-20.04
-    needs:
-      - init
-    environment:
-      name: ${{ startsWith(github.ref_name, 'snyk-') && 'snyk' || github.ref_name }}
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - uses: ./.github/actions/setup
-      - name: Test
-        run: run test
-
   e2e:
     runs-on: ubuntu-20.04
     needs:

diff --git a/mocks/handlers/api/search.ts b/mocks/handlers/api/search.ts
@@ -34,7 +34,7 @@ const defaultApiSearchHandler = http.post<PathParams, SearchQueryBody>(
         },
         hits: {
           total: {
-            value: 654,
+            value: itemList.length,
             relation: "eq",
           },
           max_score: 1,

diff --git a/react-app/src/components/ErrorAlert/ErrorAlert.test.tsx b/react-app/src/components/ErrorAlert/ErrorAlert.test.tsx
@@ -9,7 +9,7 @@ describe("ErrorAlert", () => {
     render(<ErrorAlert error={{} as ReactQueryApiError} />);
 
     expect(screen.queryByText("Error")).toBeInTheDocument();
-    expect(screen.queryByText("An error has occured")).toBeInTheDocument();
+    expect(screen.queryByText("An error has occurred")).toBeInTheDocument();
   });
 
   it("renders with error message", () => {

diff --git a/react-app/src/components/ErrorAlert/index.tsx b/react-app/src/components/ErrorAlert/index.tsx
@@ -3,7 +3,7 @@ import { XCircleIcon } from "lucide-react";
 import { ReactQueryApiError } from "shared-types";
 
 export const ErrorAlert = ({ error }: { error: ReactQueryApiError }) => {
-  let message = "An error has occured";
+  let message = "An error has occurred";
 
   if (error?.response?.data?.message) {
     message = error.response.data.message;

diff --git a/react-app/src/components/Opensearch/main/Filtering/Chipbar/index.test.tsx b/react-app/src/components/Opensearch/main/Filtering/Chipbar/index.test.tsx
@@ -435,7 +435,7 @@ describe("FilterChips", () => {
 
     it("should handle clearing all", async () => {
       const { user } = setup(DEFAULT_FILTERS);
-      screen.debug();
+
       await user.click(screen.getByText("Clear All").parentElement);
       expect(screen.queryByText("State: Maryland, MD")).toBeNull();
       expect(screen.queryByText("Authority: CHIP SPA")).toBeNull();

diff --git a/react-app/src/components/Opensearch/main/index.test.tsx b/react-app/src/components/Opensearch/main/index.test.tsx
@@ -252,7 +252,7 @@ describe("OsMainView", () => {
       const recordsSelect = within(screen.getByTestId("pagination")).getByLabelText(
         "Records per page:",
       );
-      screen.debug(recordsSelect);
+
       await user.selectOptions(recordsSelect, ["50"]);
       expect(recordsSelect).toHaveValue("50");
       const expectedQueryString = getDashboardQueryString({