Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Remove text extractor from VPC #1152

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[Hotfix] Remove text extractor from VPC #1152

merged 1 commit into from
Jan 26, 2024

Conversation

cgodwin1
Copy link
Contributor

@cgodwin1 cgodwin1 commented Jan 26, 2024 •
edited
Loading

Resolves #n/a

Description-

This PR should permanently fix the "out of IPs" error we receive when having more than a couple deploys of the text extractor.

This pull request changes...

  • Removes the text extractor from the private VPCs.
  • Removes REST API logging since we aren't using that anyway.

Steps to manually verify this change...

  1. Verify this PR deploys.
  2. Go through the normal steps to extract a random supported file on the experimental deploy (admin -> uploaded files -> upload a file -> "Get content" -> refresh until "index populated" is populated). This check makes sure that removing the text extractor from the VPC doesn't impede its functionality (like S3 access).

@github-actions GitHub Actions
Copy link

✨ See the Django Site in action ✨

peggles2
peggles2 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@peggles2 peggles2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cgodwin1 cgodwin1 merged commit a1a84f5 into main Jan 26, 2024
18 checks passed
@cgodwin1 cgodwin1 mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peggles2 peggles2 peggles2 approved these changes

@PhilR8 PhilR8 Awaiting requested review from PhilR8 PhilR8 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgodwin1 @peggles2