Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EREGCSC-2906 Mitigate IP address issue #1518

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

cgodwin1
Copy link
Contributor

@cgodwin1 cgodwin1 commented Jan 16, 2025

Resolves #2906

Description-

Early in 2024 we were receiving experimental deploy failures due to one of our subnets being out of available IPv4 addresses. To mitigate this, we removed the text extractor from the VPC. The eCFR/FR parsers were already not in the VPC, so this permanently resolved the issue when deploying with Serverless.

Recently with the transition work to CDK, we started receiving this error again because all experimental deploy lambda functions were being assigned to the VPC. This PR fixes that.

This pull request changes...

  • Text extractor + FR parser + eCFR parser lambdas removed from the VPC

Steps to manually verify this change...

  1. Confirm all green check marks (for the first time in a while!) This means all lambdas are deploying properly.
  2. If better validation is desired, log into the VPN and go to the dev AWS account.
  3. Go to the VPC dashboard, then on the left sidebar click "Subnets".
  4. For each of the private subnets on that page, copy the "Subnet ID" field to your clipboard.
  5. Run the following AWS CLI command: aws ec2 describe-network-interfaces --filters Name=subnet-id,Values=<SUBNET ID HERE> | grep Description | grep 1518 (replace <SUBNET ID HERE> with your subnet ID, for example subnet-123abc).
  6. You should see an empty response for each subnet. This confirms that no resources related to this pull request are associated with any of eRegs' private subnets.

Copy link

✨ See the Django Site [in action][1] ✨

[1]:

Copy link

✨ See the Django Site [in action][1] ✨

[1]:

@cgodwin1 cgodwin1 marked this pull request as ready for review January 16, 2025 20:05
@cgodwin1 cgodwin1 requested a review from PhilR8 as a code owner January 16, 2025 20:05
@cgodwin1 cgodwin1 added the Needs Review This PR needs a code review label Jan 16, 2025
Copy link
Contributor

@PhilR8 PhilR8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25 green check marks! LGTM!

@PhilR8 PhilR8 added Approved and removed Needs Review This PR needs a code review labels Jan 17, 2025
@cgodwin1 cgodwin1 merged commit 18576bc into main Jan 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants