Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flat file genotype/population calculation #1141

Open
wants to merge 11 commits into
base: postreleasefix/114
Choose a base branch
from

Conversation

nakib103
Copy link
Contributor

@nakib103 nakib103 commented Jan 2, 2025

  • utils.nf
    Have a common place for all EVA related function. As we were replicating them in multiple script it was getting cumbersome to update.

    • sub get_vcf_content_types:
      • Improve checking of population type - query database to check sub is_freq_from_gts is set.
      • Fix checking of genotype type - sub genotype_samples_exists was missing some cases where sample name had population prefix from database and not vcf_config.json.
  • Species list

    • (species_list.pl) Fixed missing genotype ticks for some database species.
    • (species_list_vcf.pl) Added population column for VCF species (before it was only genotypes).
    • (species_list_vcf.pl) Fixed count difference in the VCF species table (before they were missing).
  • Species detailed list (TBD)

    • Add species with population data (American mink and Nile tilapia).
    • Instead of having same count for population and genotype, irrespective of what data the VCF file have, we now have the count in appropriate column and leave the other column blank if applicable.
  • Sources list

    • Fix mismatch between "Species list" (top-right) and actual table of the species; by preventing adding hidden empty row -
    • Fix no color change in alternating rows in EVA species
    • For new version of EVA script now support adding info in "Species list" (top-right) and color change in table.

@nakib103 nakib103 marked this pull request as draft January 2, 2025 17:01
@nakib103 nakib103 marked this pull request as ready for review January 18, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants