fix(lazyload): move 'root' provider to provideMatomo #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelRoux
force-pushed
the
fix/lazyload
branch
2 times, most recently
from
6359117 to
326ccbe
Compare
Closed
|
Hi @raphael22 I've pushed some new code, could you please confirm that version |
EmmanuelRoux
force-pushed
the
fix/lazyload
branch
from
326ccbe to
2d9b301
Compare
|
Working on stackblitz exemple! |
EmmanuelRoux
force-pushed
the
fix/lazyload
branch
from
7d9e503 to
2b1fe2a
Compare
EmmanuelRoux
added a commit
that referenced
this pull request
Jan 3, 2025
# [6.4.0](v6.3.1...v6.4.0) (2025-01-03) ### Bug Fixes * correctly resolve deferred configuration when using `manual` initialization mode ([da82506](da82506)), closes [#102](#102) ### Features * add `getCustomData` and `setCustomData` tracker API methods ([e76564c](e76564c)) * add optional _custom data_ parameter to event tracking ([0cdda40](0cdda40)) * add optional _custom data_ parameter to goal tracking ([6e21b91](6e21b91)) * add optional _custom data_ parameter to link tracking ([cfb42b1](cfb42b1)) * add optional _custom data_ parameter to site search tracking ([fa35f1c](fa35f1c)), closes [#96](#96) * allow providing Matomo in lazy-loaded components/modules ([#98](#98)) ([45a5a0e](45a5a0e))
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Jan 6, 2025
|
Testing docs need to be updated so you need to use |
EmmanuelRoux
pushed a commit
that referenced
this pull request
Jan 14, 2025
EmmanuelRoux
added a commit
that referenced
this pull request
Jan 14, 2025
# [7.0.0](v6.4.1...v7.0.0) (2025-01-14) ### Bug Fixes * correctly inject legacy `MatomoRouterModule` and `NgxMatomoRouterModule` ([c2f7fda](c2f7fda)), closes [#105](#105) [#104](#104) * correctly resolve deferred configuration when using `manual` initialization mode ([f0bb6c1](f0bb6c1)), closes [#102](#102) * prepare testing api update ([0471e41](0471e41)) ### Features * add compatibility with Angular 19 (#101) ([bfae2b7](bfae2b7)), closes [#99](#99) [#103](#103) * add new `withPageUrlProvider` feature and allow functional-style provider ([3d002d8](3d002d8)) * allow providing Matomo in lazy-loaded components/modules (#98) ([2982fc4](2982fc4)), closes [#97](#97) * allow providing page url as promise ([5bb76a4](5bb76a4)) ### Breaking changes * Angular v19 is now required as peer dependency * Some of your tests may be broken, you may need to provide Matomo in `TestBed` using `provideMatomoTesting()`. ### Deprecations * `MatomoTestingTracker.setMatomoInstance` has been deprecated, provide a `MATOMO_TESTING_INSTANCE` DI token instead
|
@viceice Version 6.4.0 has been reverted in 6.4.1 (and is now deprecated) This PR is now included in version 7.0.0 and has breaking changes. For testing, |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a first try at moving provider from root.
My repro start with this but not sure of what to do about router/form feature.
I moved MatomoInitializerService initialize in its constructor, otherwise I was stuck with no config error, tried to force INTERNAL_CONFIG before but a bit lost there.