chore: revert unrelated change

EmmanuelRoux · Jan 3, 2025 · 2b1fe2a · 2b1fe2a
1 parent 2d9b301
commit 2b1fe2a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/projects/ngx-matomo-client/core/tracker/matomo-initializer.service.ts b/projects/ngx-matomo-client/core/tracker/matomo-initializer.service.ts
@@ -76,9 +76,6 @@ export class MatomoInitializerService {
 
     if (isAutoConfigurationMode(this.config)) {
       this.injectMatomoScript(this.config);
-    } else {
-      // Mode is manual, immediately resolve deferred config
-      this.deferredConfig.markReady(this.config);
     }
   }, ALREADY_INITIALIZED_ERROR);
 

diff --git a/projects/ngx-matomo-client/form-analytics/matomo-form-analytics-initializer.service.spec.ts b/projects/ngx-matomo-client/form-analytics/matomo-form-analytics-initializer.service.spec.ts
@@ -137,8 +137,8 @@ describe('MatomoFormAnalyticsInitializer', () => {
 
   it('should throw when trying to inject default script without tracker configuration', async () => {
     // Given
-    let handleError: (error: unknown) => void;
-    const caughtError = new Promise(resolve => (handleError = resolve));
+    let resolveCaughtError: (error: unknown) => void;
+    const caughtError = new Promise(resolve => (resolveCaughtError = resolve));
 
     await setUp(
       {
@@ -150,18 +150,22 @@ describe('MatomoFormAnalyticsInitializer', () => {
       [
         {
           provide: ErrorHandler,
-          useFactory: (): ErrorHandler => ({ handleError }),
+          useValue: {
+            handleError: error => resolveCaughtError(error),
+          } satisfies ErrorHandler,
         },
       ],
     );
 
     // Then
-    await expectAsync(caughtError).toBeResolvedTo(
-      new Error(
-        'Cannot resolve default matomo FormAnalytics plugin script url. ' +
-          'Please explicitly provide `loadScript` configuration property instead of `true`',
-      ),
-    );
+    // TODO change to expect error when #102 is fixed
+    await expectAsync(caughtError).toBePending();
+    // await expectAsync(caughtError).toBeResolvedTo(
+    //   new Error(
+    //     'Cannot resolve default matomo FormAnalytics plugin script url. ' +
+    //       'Please explicitly provide `loadScript` configuration property instead of `true`',
+    //   ),
+    // );
     expectNoInjectedScript();
   });