Fix tests and build warnings #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psgreco
force-pushed
the
master-fixlock
branch
from
a86b0c0 to
6363ec5
Compare
psgreco
force-pushed
the
master-fixlock
branch
from
6363ec5 to
6b3af57
Compare
psgreco
force-pushed
the
master-fixlock
branch
2 times, most recently
from
0787645 to
b92a3ce
Compare
delta1
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In feature_discounct, the created tx can be of 2 different weights, we need to make sure we don't fail erroneously.
Newer gcc versions complain about mixing int and enum, so we need to do the 0 from the enum.
TSAN revealed an unlocked access to pindexBestHeader, so it's moved inside the lock
Fixes an issue in windows builds accessing the cookie file with special characters in the path.
Also addresses some issues seen in Win 64 native functional tests, doesn't fully fix the issues, but it's a step in the right direction.
Fixes: #1406 #1422