Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.0 #246

Merged
merged 3 commits into from
Nov 14, 2021
Merged

v2.1.0 #246

merged 3 commits into from
Nov 14, 2021

Conversation

leepc12
Copy link
Contributor

@leepc12 leepc12 commented Nov 12, 2021

Hotfix for chip.subsample_reads bug.

This bug was introduced in v1.2.2 (6/13/2019).
chip.ctl_subsample_reads is ignored and chip.subsample_reads (0: disabled by default) is used for subsampling both experiment replicates and controls.

Outputs are affected by this bug if chip.subsample_reads is non-zero and chip.pipeline_type is tf (default) or histone.
Since chip.subsample_reads is 0 (disabled) by default, outputs are not affected if you used a default set of parameters.

The following outputs can be affected by this bug:

  • Control TAG-ALIGNs and all its downstream analyses.
  • Such downstream outputs include all kinds of peaks (spp, macs2, idr, overlap).

@leepc12 leepc12 merged commit 23a7044 into master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant