MdeModulePkg/Application/UiApp: Customize front page #115
Conversation
|
Wanted to give the front page a little better look and feel + RTC settings. Sample view from QEMU:
|
|
The only problem I see with the current code is that EDK2 refreshes the banners on top and the hotkey help section on the bottom every second now. The refreshing is not eye-friendly as these sections simply blink (probably are being fully reprinted). I have noticed that when the date and time VFR opcodes are placed in a submenu (which has a title frame), the title and hotkey help sections do not blink. I have to dig a little bit more to find a way to stop refreshing of these sections, if not needed (thus draft). |
Signed-off-by: Michał Żygowski <[email protected]>
miczyg1
force-pushed
the
front_page_customization
branch
from
b317d97 to
7bb369c
Compare
|
Maybe drop "Select Language"? If addition of time and date doesn't break tests, this change shouldn't either and only English language is supported anyway. |
French is supported to some extent though. Besides I am not sure if the language variable would be populated properly if I remove it. Also we have plans for more languages Dasharo/dasharo-issues#526 |
There was a problem hiding this comment.
Yeah, that flickering is a bit annoying.
If we don't need an extra empty line, can make things more symmetric:
I like the changes, although would prefer more granular commits (current one is "through away stuff, bring new stuff in") or at least list of things changed in the commit message. EDK's code is far from being readable to simply read changed lines.
Also wanted to suggest better ordering of menu items, but looks like it needs introduction of some weighs/priorities for UiListThirdPartyDrivers() to take into account (I thought the order is just hard-coded somewhere).
| #language fr-FR "C'est l'aide pour la Date (mois/jour/année)." | ||
| #string STR_TIME_PROMPT #language en-US "System Time" | ||
| #language fr-FR "Le temps du système" | ||
| #string STR_TIME_HELP #language en-US "This is the help for the Time (hour/minute/second). Time is represented in local time zone." |
There was a problem hiding this comment.
Help strings for time and date need an improvement ("This is the help" part for sure, "This is the option one adjusts" for "Select Language" always looked quite ridiculus).
There was a problem hiding this comment.
Right, taken from SampleDriverDxe and didn't update it yet.
Looks better indeed.
Yes I can do that, for now I just dumped the changes to remote and that's all.
It may be just an order of handles returned by HiiGetHiiHandles. I wouldn't be surprised if the order of handles is connected to the order of DXE driver execution, or even the order of the drivers inside the flash image. |
|
That was some nice suggestion, perhaps we should go back to it after rebase. |
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
No description provided.