-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3710 flagging journals #2426
Open
richard-jones
wants to merge
91
commits into
develop
Choose a base branch
from
feature/3710_flagging_journals
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
1f239a0
prototyping on flagging feature
richard-jones 98c66dd
some prototyping around converting notes to flags
richard-jones 80cdba3
remove erroneous import
richard-jones a598eb9
remove convert_to_flag converter
amdomanska 155d846
Merge branch 'develop' into feature/3710_flagging_journals
amdomanska 33d0d69
remove convert to flag continued
amdomanska f57f728
add flag structs to the notes
amdomanska 5bd175e
add flag to the model and save from the form as a flag
amdomanska ed6c0b8
add 'clear flag' functionality
amdomanska 7070a83
add 'has_flag' to index
amdomanska e58fb2a
add 'notes_except_flags' and 'flags' to journal model properties; all…
amdomanska 2e600fb
display existing flag correctly in the form
amdomanska 1097dad
make flags field repeatable with max 2 values - one for current, one …
amdomanska 8763161
add resolve/unresolve flag
amdomanska 0b29b96
change resolved flag into the note
amdomanska b68c9c1
only one flag ensured; buttons disabled and enabled correctly; resolv…
amdomanska b711329
now backend handled resolving and adding well
amdomanska 0e0873d
automatic resolved by and resolved_on
amdomanska 0ff3317
add accounts to assigned_to
amdomanska 41b0759
add labels and change the order
amdomanska cb8139d
control who can add the field
amdomanska ed259a7
control who can add the field - fixed
amdomanska 9870773
filters added; sort added but mapping is off
amdomanska 48f49e8
Sorting by deadline
amdomanska 167d7d7
Add info about flags to todo cars
amdomanska e0d86fe
UI filter in dashboard works
amdomanska e0b60a3
remove accidental file
amdomanska ae610ae
manage string None as filter
amdomanska a0d0b5f
sorting works
amdomanska d0f086f
flagged to me dashboard filter works
amdomanska 0cc7416
small changes in fields names
amdomanska 01f62d4
set up flag editing permissions
amdomanska 17b16d2
styling: 1st pass
amdomanska ce5f444
add flag icon to flags inside journal form
amdomanska e095c46
fix flag_details value
amdomanska c081a32
styling: 2st pass
amdomanska af30681
fix filters in dashboard
amdomanska 37e7e8a
add information about flags to search results
amdomanska 3dd4805
styling pass 3; refactoring pass 1
amdomanska 0d44d4f
Merge branch 'develop' into feature/3710_flagging_journals
amdomanska 4eadaa2
revert dev_basics file
amdomanska 4e88cb5
PR cleanup: add while line
amdomanska 49c1090
PR cleanup: remove print
amdomanska 60c1471
PR cleanup: change order of lines to make diff clearer
amdomanska 1a204cf
PR cleanup: move FAR_IN_THE_FUTURE date to dates lib
amdomanska 93faf9a
PR cleanup: use defined property
amdomanska 0a4a00f
PR cleanup: revert beforeunload in application_form
amdomanska 404aa54
PR cleanup: remove unnecessary space
amdomanska 24a0845
PR cleanup: revert unnecessary change in autoccomplete
amdomanska c754797
remove unnecessary templates
amdomanska 65beebf
remove unnecessary script
amdomanska d67960d
remove extra doaj.session.currentUser
amdomanska 8a9e531
PR cleanup: newline in settings
amdomanska a8f0aef
PR cleanup: revert changes in core.py
amdomanska 3377644
PR cleanup: remove prints
amdomanska 3feecd3
Merge branch 'develop' into feature/3710_flagging_journals
richard-jones 365e291
hide newFlagGroup correctly
amdomanska 6aa466b
show new flag correctly
amdomanska a08d860
extract dates js library
amdomanska 1852def
remove moment.js and add refactoring functions to doaj.dates lib
amdomanska 49aad78
remove moment.js
amdomanska d331b1c
fix typo after dates refactoring
amdomanska 86f6c8a
fix formulaic
amdomanska 3780552
fix Notes
amdomanska 5e71ebb
fix autocomplete
amdomanska 46d72ab
fix autocomplete p2
amdomanska 91513e1
remove required attribute from flag_assignee, add short help
amdomanska 0cfe8f4
improve short help
amdomanska f9a34b6
style short help
amdomanska ab07ed2
fix the flagExists loop; improve dateParse functions
amdomanska d4cec93
hide deadline when appropriate
amdomanska 882ffd9
adjust flag display
amdomanska 94d40c3
Merge branch 'develop' into feature/3710_flagging_journals
amdomanska fe59f7e
reverse dashboard code
amdomanska 22aa207
reverse unnecessary changes
amdomanska 79277ad
remove unnecessary code from dashboard js; add static url for flagged…
amdomanska ccb6693
add rule to the dashboard
amdomanska 48a3238
clean up js in dashboard template
amdomanska 029f7a1
remove unnecessary template
amdomanska 74fea92
change disabled inputs on resolve on readonly to send data correctly
amdomanska 1f4f4bf
add resolved flag field to shared structs
amdomanska 5cb295f
fix far in the future function
amdomanska d713068
fix resolving flag; move transforming resolved flag from crosswalk to…
amdomanska 6e14f61
display flagged to me todos
amdomanska aebad8c
remove na, ur and oh rules from flagged journals
amdomanska fed5d1a
fix rules display
amdomanska 923ff13
introduce 2 rules for flagged todos
amdomanska 4a01e3d
remove obsolete method
amdomanska faaed1d
remove obsolete import
amdomanska 4ddf169
move resolved flag message to Messages module
amdomanska 56cef2d
add rule that is too general
amdomanska File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,104 @@ | ||
.editorial-panel { | ||
margin-top: 0; | ||
|
||
.form__question { | ||
select, textarea, input { | ||
width: 100%; | ||
.flag--resolved { | ||
position: relative; | ||
opacity: 0.2; /* Set opacity of entire div */ | ||
} | ||
} | ||
|
||
hr { | ||
margin: $spacing-02; | ||
} | ||
.flag--resolved::before { | ||
content: "RESOLVED"; /* The word to display as the stamp */ | ||
position: absolute; | ||
top: 50%; | ||
left: 50%; | ||
transform: translate(-50%, -50%) rotate(-45deg); /* Center and rotate the text */ | ||
font-size: 3em; /* Adjust the size of the stamp */ | ||
color: rgba(0, 0, 0, 0.5); /* Light black color for the stamp */ | ||
z-index: 10; /* Place the stamp behind the button */ | ||
pointer-events: none; /* Ensure the stamp doesn't interfere with interactions */ | ||
opacity: 0.6; /* Make the stamp slightly transparent */ | ||
letter-spacing: 0.2em; /* Adjust the spacing between letters for the stamp */ | ||
font-weight: bold; | ||
} | ||
.editorial-panel__content { | ||
.form__question.editorial-panel__question { | ||
padding: 0 !important; | ||
.editorial-panel__question-header { | ||
padding: .5rem; | ||
align-items: flex-start; | ||
label, p { | ||
margin: 0; | ||
} | ||
} | ||
.editorial-panel__legend { | ||
display: flex; | ||
align-items: center; | ||
gap: .5rem; | ||
padding: 0 .5rem; | ||
margin-bottom: .375rem; | ||
} | ||
.editorial-panel__questions-content { | ||
.form-inputs--container { | ||
&:has(input[type="hidden"]) { | ||
|
||
@media (min-width: 992px) { | ||
position: -webkit-sticky; | ||
position: sticky; | ||
top: 100px; | ||
} | ||
&:has(label) { | ||
label { | ||
font-size: .75rem; | ||
margin-bottom: 0; | ||
margin-left: .5rem; | ||
.form__question--optional { | ||
font-size: .75rem; | ||
} | ||
} | ||
} | ||
&:has(svg) { | ||
position: relative; | ||
width:100%; | ||
svg { | ||
position: absolute; | ||
left: .5rem; | ||
top:50%; | ||
transform: translateY(-25%); | ||
z-index: 1; | ||
} | ||
.select2-choice { | ||
.select2-chosen { | ||
padding-left: calc(.5rem + 20px); | ||
} | ||
} | ||
} | ||
input { | ||
white-space: nowrap; | ||
overflow: hidden; | ||
text-overflow: ellipsis; | ||
} | ||
|
||
&__wrapper { | ||
display: flex; | ||
flex-direction: column; | ||
max-height: calc(100vh - 75px - 1.5rem - 25px); //(full viewport)-(nav height)-(top padding)-(bottom padding) | ||
} | ||
span.spanPretendingToBeInput { | ||
display: block; | ||
&:has(svg) { | ||
display: flex; | ||
align-items: flex-start; | ||
gap: .5rem; | ||
} | ||
background-color: $disabled; | ||
width: 100%; | ||
padding: 0.5rem; | ||
margin-bottom: .375rem; | ||
font-style: italic; | ||
|
||
&__content { | ||
flex: 1; | ||
overflow-y: scroll; | ||
span { | ||
white-space: normal; | ||
} | ||
} | ||
|
||
select, textarea, input { | ||
display: block; | ||
} | ||
input:disabled ~ label { | ||
display: none; | ||
} | ||
} | ||
[class^="control_buttons_div"] { | ||
padding-left: .5rem; | ||
padding-right: .5rem; | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed