Feature/3710 flagging journals #2426

richard-jones · 2024-10-17T12:43:08Z

Issue: https://github.com/DOAJ/doajPM/issues/3710

Flagging Journals and Applications

Adds a flag dialogue to the form to allow a note to be set with a flag.

This PR...

Developer Checklist

Developers should review and confirm each of these items before requesting review

Code meets acceptance criteria from issue
Unit tests are written and all pass
User Test Scripts (if required) are written and have been run through
Project's coding standards are met
- No deprecated methods are used
- No magic strings/numbers - all strings are in constants or messages files
- ES queries are wrapped in a Query object rather than inlined in the code
- Where possible our common library functions have been used (e.g. dates manipulated via dates)
- Cleaned up commented out code, etc
- Urls are constructed with url_for not hard-coded
Code documentation and related non-code documentation has all been updated
- Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
- Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
Migation has been created and tested
There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

Code meets acceptance criteria from issue
Unit tests are written and all pass
User Test Scripts (if required) are written and have been run through
Project's coding standards are met
- No deprecated methods are used
- No magic strings/numbers - all strings are in constants or messages files
- ES queries are wrapped in a Query object rather than inlined in the code
- Where possible our common library functions have been used (e.g. dates manipulated via dates)
- Cleaned up commented out code, etc
- Urls are constructed with url_for not hard-coded
Code documentation and related non-code documentation has all been updated
- Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
- Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
Migation has been created and tested
There is a recent merge from develop

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run by reviewers

Deployment

What deployment considerations are there? (delete any sections you don't need)

Configuration changes

What configuration changes are included in this PR, and do we need to set specific values for production

Scripts

What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).

Migrations

What migrations need to be run to deploy this

Monitoring

What additional monitoring is required of the application as a result of this feature

New Infrastructure

What new infrastructure does this PR require (e.g. new services that need to run on the back-end).

Continuous Integration

What CI changes are required for this

…ow order_notes to order without flags

…for new; display it correctly

…ing the flag and adding new works great

… filter in dashboard

… application processor

amdomanska · 2025-01-22T14:59:27Z

portality/constants.py

@@ -43,6 +43,7 @@
 LINK_TYPE_FULLTEXT = "fulltext"

 # ~~-> Todo:Service~~
+TODO_ASSIGNED_TO_ME = "todo_assigned_to_me"


amdomanska · 2025-01-22T15:01:03Z

portality/lib/coerce.py

@@ -24,6 +24,12 @@ def datify(val):

    return datify

+def find_earliest_date(dates_arr, dates_format, out_format=None):


is that used?

amdomanska · 2025-01-22T15:20:47Z

portality/view/editor.py

@@ -29,8 +29,9 @@ def restrict():
 @ssl_required
 def index():
    # ~~-> Todo:Service~~
+    flag_filter = request.values.get("flag_filter", "a2me")


richard-jones and others added 30 commits October 10, 2024 10:34

prototyping on flagging feature

1f239a0

some prototyping around converting notes to flags

98c66dd

remove erroneous import

80cdba3

remove convert_to_flag converter

a598eb9

Merge branch 'develop' into feature/3710_flagging_journals

155d846

remove convert to flag continued

33d0d69

add flag structs to the notes

f57f728

add flag to the model and save from the form as a flag

5bd175e

add 'clear flag' functionality

ed6c0b8

add 'has_flag' to index

7070a83

add 'notes_except_flags' and 'flags' to journal model properties; all…

e58fb2a

…ow order_notes to order without flags

display existing flag correctly in the form

2e600fb

make flags field repeatable with max 2 values - one for current, one …

1097dad

…for new; display it correctly

add resolve/unresolve flag

8763161

change resolved flag into the note

0b29b96

only one flag ensured; buttons disabled and enabled correctly; resolv…

b68c9c1

…ing the flag and adding new works great

now backend handled resolving and adding well

b711329

automatic resolved by and resolved_on

0e0873d

add accounts to assigned_to

0ff3317

add labels and change the order

41b0759

control who can add the field

cb8139d

control who can add the field - fixed

ed259a7

filters added; sort added but mapping is off

9870773

Sorting by deadline

48f49e8

Add info about flags to todo cars

167d7d7

UI filter in dashboard works

e0d86fe

remove accidental file

e0b60a3

manage string None as filter

ae610ae

sorting works

a0d0b5f

flagged to me dashboard filter works

d0f086f

amdomanska added 27 commits December 9, 2024 12:35

fix autocomplete

5e71ebb

fix autocomplete p2

46d72ab

remove required attribute from flag_assignee, add short help

91513e1

improve short help

0cfe8f4

style short help

f9a34b6

fix the flagExists loop; improve dateParse functions

ab07ed2

hide deadline when appropriate

d4cec93

adjust flag display

882ffd9

Merge branch 'develop' into feature/3710_flagging_journals

94d40c3

reverse dashboard code

fe59f7e

reverse unnecessary changes

22aa207

remove unnecessary code from dashboard js; add static url for flagged…

79277ad

… filter in dashboard

add rule to the dashboard

ccb6693

clean up js in dashboard template

48a3238

remove unnecessary template

029f7a1

change disabled inputs on resolve on readonly to send data correctly

74fea92

add resolved flag field to shared structs

1f4f4bf

fix far in the future function

5cb295f

fix resolving flag; move transforming resolved flag from crosswalk to…

d713068

… application processor

display flagged to me todos

6e14f61

remove na, ur and oh rules from flagged journals

aebad8c

fix rules display

fed5d1a

introduce 2 rules for flagged todos

923ff13

remove obsolete method

4a01e3d

remove obsolete import

faaed1d

move resolved flag message to Messages module

4ddf169

add rule that is too general

56cef2d

amdomanska reviewed Jan 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/3710 flagging journals #2426

Feature/3710 flagging journals #2426

richard-jones commented Oct 17, 2024 •

edited

Loading

amdomanska Jan 22, 2025

amdomanska Jan 22, 2025

amdomanska Jan 22, 2025

		@@ -24,6 +24,12 @@ def datify(val):

		return datify

		def find_earliest_date(dates_arr, dates_format, out_format=None):

Feature/3710 flagging journals #2426

Are you sure you want to change the base?

Feature/3710 flagging journals #2426

Conversation

richard-jones commented Oct 17, 2024 • edited Loading

Flagging Journals and Applications

Developer Checklist

Reviewer Checklist

Testing

Deployment

Configuration changes

Scripts

Migrations

Monitoring

New Infrastructure

Continuous Integration

amdomanska Jan 22, 2025

Choose a reason for hiding this comment

amdomanska Jan 22, 2025

Choose a reason for hiding this comment

amdomanska Jan 22, 2025

Choose a reason for hiding this comment

richard-jones commented Oct 17, 2024 •

edited

Loading